-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add format option to subscriptions to only show condensed notification messages #1046
Conversation
Thanks for taking time to contribute! We'll check this out soon and let you know if we have any questions or feedback. |
Codecov Report
@@ Coverage Diff @@
## master #1046 +/- ##
==========================================
+ Coverage 97.01% 97.03% +0.01%
==========================================
Files 157 157
Lines 2649 2663 +14
Branches 362 364 +2
==========================================
+ Hits 2570 2584 +14
Misses 75 75
Partials 4 4 |
Would it be possible to also add the formatting option to the regular messages' previews using this, or is that a completely different thing? |
No, it's not possible. This format option affects only notifications from issue:opened and pr:opened events. |
what are we waiting on to get this merged? strongly looking forward to this feature! |
@wilhelmklopp - Any chance you could help move this forward? @ryamaguchi0220 - could you add a before and after screenshot so we can see what the condensed version looks like? |
Hey! I'm no longer working on this project, but @tebriel may be able to help 🙂 |
Hi,
Actually, I added test code as much as I can but, it has not been tested on Slack yet because I could not build my testing environment well (followed this guide). I'm sorry but could anyone test it on Slack and add the screenshots instead of me? |
any update on this? 💯 |
@tebriel are there any plans to merge this? folks in my team already hate me for my decision to add github bot to our channel due to all this spam. still promising them to do something with that. but their patience cannot long forever 8) |
@aukobara I'm no longer on the team at GitHub that maintains the Slack Integration, the new team is spinning up and is aware of the backlog of features on this repo. 🤞🏻 that they can assist soon! |
Is there any way we could help in moving this forward? 🙏 |
@ryamaguchi0220 Thanks for this PR. We have recently taken ownership of Slack app and we are currently not taking any PRs as we are working on platform level improvements. We will move this to PR to Issue and and take it up as a feature request. Thanks for your support. |
@ashokirla I respect your decision. I just think that it might be a good idea for you to work on #1127 as soon as possible. |
Closing this PR and moving it to issue here. |
Close #162
This PR adds format option to subscriptions to only show condensed notification messages.
Usage
The value can be one of:
full
- Full version message (default)condensed
- Condensed version message