Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi, I've investigated this issue #634
The problem is :
createGridResizer
receive old values for sizes ( width and height, they're equal with previous, so we don't update anything ).But the callback for
viewportElement
receives actual valueFitToViewport
story ( just chose mobile device in storybook header and rotate twice )minWidth
andminHeight
css properties seems to break the thing , removing them fixes the issue (FitToViewportAdjusted
story)I'm not sure it's ok to remove those properties as it might break in some cases .. I'll look deeper later, but maybe someone has idea