Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle resize for vgrid #648

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vilgeforc5
Copy link

hi, I've investigated this issue #634

The problem is :

  1. When mobile device is rotated, the callbacks for cell items in createGridResizer receive old values for sizes ( width and height, they're equal with previous, so we don't update anything ).
    But the callback for viewportElement receives actual value
  2. You can reproduce the issue with FitToViewport story ( just chose mobile device in storybook header and rotate twice )
  3. The minWidth and minHeight css properties seems to break the thing , removing them fixes the issue ( FitToViewportAdjusted story)

I'm not sure it's ok to remove those properties as it might break in some cases .. I'll look deeper later, but maybe someone has idea

  add reproducable example of bug to VGrid.stories.tsx
@vilgeforc5 vilgeforc5 force-pushed the fix/handle-resize-for-vgrid branch from 10a9855 to 7bfeaaf Compare March 10, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants