Lint #41
Open
Lint #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The unicode bullet (•) and nbsp were being used in list entry prefix, however they are not recognised by Markdown syntax.
An indented paragraph and list render incorrectly
Uses both Ruby and Javascript linter.
|
While the other two changes fix actual rendering problems, this changeset includes changes which do not improve the rendering as far as I can see, and the necessary rules can all be disabled if you dont like them. I've avoided fixing the lint errors, to keep this changeset managable. |
|
Here is the output : https://travis-ci.org/jayvdb/PocketEuler/builds/137073407 |
|
👍 |
| @@ -0,0 +1,18 @@ | |||
| { | |||
| "comment": "Rules for the style guide at http://www.cirosantilli.com/markdown-style-guide/", | |||
There was a problem hiding this comment.
copy and paste error.
|
@jayvdb should this be closed? |
|
I'd like to revise it after the other fixes are merged, as it provides a much saner baseline for lint rules. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36
This change is