Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: updated form modal with loading state UI #7838

Merged
merged 2 commits into from
Mar 26, 2025

Conversation

jonwaldstein
Copy link
Contributor

@jonwaldstein jonwaldstein commented Mar 26, 2025

Description

Our current form modal does not have a loading UI. The experience is lack luster. This enhances the UX with an initial loading state. This is meant to be improved even further in the future but at least it's a start 😄

Affects

The form modal UI

Visuals

Screen.Recording.2025-03-26.at.2.04.08.PM.mov

Testing Instructions

  • Use the donation form block on a page set to modal
  • Try different form designs

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@jonwaldstein jonwaldstein marked this pull request as ready for review March 26, 2025 18:07
@JasonTheAdams
Copy link
Contributor

YES!! Thank you!! 🥇

@JasonTheAdams
Copy link
Contributor

Extra points if you add a transition such that the loading container spreads out to the final size of the form. 😁

@glaubersilva glaubersilva self-requested a review March 26, 2025 18:57
Copy link
Contributor

@glaubersilva glaubersilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonwaldstein Niiice! Much better now.

I'm approving it because what this PR proposes to do is working great with all form templates, and the overall code looks good to me.

However, another thing that keeps bothering me about this modal is the weird vertical scroll displayed in the Edge and Chrome browsers on Windows - check the attached screenshots for reference. This is probably one of these UX improvements that we'll need to do in subsequent PRs.

image

image

@jonwaldstein
Copy link
Contributor Author

@glaubersilva thanks! yeah agreed, let's keep this party going 😄

@JasonTheAdams ohhh yeahh. I really want to take this thing to the next level. Just gotta keep chipping away at it 🔨

@jonwaldstein jonwaldstein merged commit b12e08f into develop Mar 26, 2025
24 checks passed
@jonwaldstein jonwaldstein deleted the refactor/form-modal-style branch March 26, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants