Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: replace campaign custom post type with page #7830

Open
wants to merge 19 commits into
base: develop
Choose a base branch
from

Conversation

jonwaldstein
Copy link
Contributor

@jonwaldstein jonwaldstein commented Mar 25, 2025

Resolves GIVE-2352

Description

We have decided to replace our initial campaign page custom post type with a general WordPress page. This will ensure wider coverage compatibility with the WordPress ecosystem in terms of front facing themes, plugins, and page builders.

With this new direction a few UX updates have been made including:

  1. Campaigns now start off in active state, but the landing page is in draft.
  2. Migrated campaigns will not create a page by default and instead will have a "Create campaign page button"
  3. If an existing campaign page gets trashed, campaigns will have a "Create campaign page button"
  4. All campaign blocks will be available on WordPress pages with a campaign selector

Affects

  • New campaigns
  • Form migrations to campaigns
  • Campaign blocks

Visuals

Screenshot 2025-03-25 at 2 34 03 PM

Testing Instructions

ZIP: https://github.com/impress-org/givewp/actions/runs/14068715829

  • Migrating existing forms to campaigns still works, can update campaign details and can create a campaign page
  • New campaigns are active, can edit campaign with default blocks, status is in draft until published
  • Campaign landing page can be publicly viewed in various WP themes and page builders
  • Campaign block works as expected with ability to create a campaign page when one is not found for campaign
  • Campaign grid works as expected and campaigns are only clickable when they have a landing page
  • When a campaign page is trashed/deleted, the campaign will show a "create campaign page" button to create a new one.
  • Campaign blocks can be used on any page

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@jonwaldstein jonwaldstein changed the title Spike: campaign pages Refactor: replace campaign custom post type with page Mar 25, 2025
@jonwaldstein jonwaldstein marked this pull request as ready for review March 25, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants