Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: prevent checkbox template from switch to controlled #7760

Merged
merged 3 commits into from
Mar 26, 2025
Merged

Fix: prevent checkbox template from switch to controlled #7760

merged 3 commits into from
Mar 26, 2025

Conversation

jonwaldstein
Copy link
Contributor

@jonwaldstein jonwaldstein commented Feb 25, 2025 •
edited
Loading

Description

This updates the checkbox template to ensure it remains as uncontrolled input.

Affects

The checkbox field

Visuals

Screenshot 2025-02-25 at 2 07 16 PM

Testing Instructions

  • Make sure custom checkbox fields work in the VFB
  • Make sure fee recovery still works
  • Make sure there are no console errors (with script debug enabled) when using a checkbox

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@jonwaldstein jonwaldstein changed the base branch from develop to release/3.22.0 February 25, 2025 19:03
@jonwaldstein jonwaldstein changed the base branch from release/3.22.0 to develop March 12, 2025 21:43
@jonwaldstein jonwaldstein marked this pull request as ready for review March 26, 2025 21:22
pauloiankoski
pauloiankoski approved these changes Mar 26, 2025
View reviewed changes
Copy link
Contributor

@pauloiankoski pauloiankoski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jonwaldstein jonwaldstein merged commit d2812b1 into develop Mar 26, 2025
24 checks passed
@jonwaldstein jonwaldstein deleted the fix/checkbox-template branch March 26, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauloiankoski pauloiankoski pauloiankoski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonwaldstein @pauloiankoski