Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use idris-ide-client #251

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

use idris-ide-client #251

wants to merge 4 commits into from

Conversation

archaeron
Copy link
Member

Work in progress to replace our own ide client with this:

https://github.com/meraymond2/idris-ide-client

@archaeron
Copy link
Member Author

idris-ide-client doesn't handle ipkg files, so I started a project to parse them, so that we can reuse that part too between the atom and the vscode plugin:
https://github.com/archaeron/idris-ipkg

@archaeron archaeron force-pushed the use-idris-ide-client branch 4 times, most recently from 7c9dddd to f82e38f Compare June 25, 2020 17:24
@archaeron
Copy link
Member Author

@melted @justjoheinz

could you test this out? :)
it's not perfect at all, but baby steps.
The code is a lot less complex and many more things are typed

@archaeron archaeron changed the title [WIP] use idris-ide-client use idris-ide-client Jun 25, 2020
@archaeron archaeron requested a review from melted June 25, 2020 17:25
@archaeron archaeron force-pushed the use-idris-ide-client branch from f82e38f to e0fa42d Compare June 25, 2020 21:09
@archaeron archaeron force-pushed the use-idris-ide-client branch from e0fa42d to 134b947 Compare June 25, 2020 22:18
@justjoheinz
Copy link
Contributor

I'll find some time at the beginning of next week. Glad to test.

@melted
Copy link
Contributor

melted commented Jun 26, 2020

I'll check it out after work

@archaeron
Copy link
Member Author

thank you!

@melted
Copy link
Contributor

melted commented Jun 29, 2020

It's crashing in idris-ide-engine's replyHandler for me. Have to pin it down a bit more.

@archaeron
Copy link
Member Author

@melted what OS and idris version are you on?
did you remember to do an npm install? (it's a bit annoying that one has to do that)

@melted
Copy link
Contributor

melted commented Jun 29, 2020

Yes, I did npm install (well, after it failed because idris-ide-engine was missing). I used it on windows. I tested with both Idris 1.3.3 and Idris 2.

I'll have some time to debug it tomorrow.

@melted
Copy link
Contributor

melted commented Jun 30, 2020

It's really weird, the messages gets sliced up wrong. It connects alright, including parsing the reply. Then when it sends a command (say Open REPL) and it gets an answer 000041(:write-string bla...), it takes 4 as the length and sends 1(:w to replyHandler.

And then it bombs the next time when rite-string bla..) is first in the buffer.

@melted
Copy link
Contributor

melted commented Jun 30, 2020

Oh yeah, there's a stray newline in the buffer.

@archaeron
Copy link
Member Author

idris2 is not yet supported by meraymond2/idris-ide-client but they are making good progress :)

thanks for testing and reporting the issue on the other repo! I had only tested this on Linux

@archaeron
Copy link
Member Author

@melted I updated to the newest version of the idris-ide-client, where the windows issue should be fixed now

could you test it out again? :)

@melted
Copy link
Contributor

melted commented Jul 9, 2020

Will do!

@justjoheinz
Copy link
Contributor

I had been out of the loop for awhile. After needing to install a typescript peer dependency (I choose npm install --save typescript@^2.0.0) I get startup errors on lines where a question mark is used to check for non null parameters. E.g.

this.holesContainer ? .appendChild(this.prettyprintHoles(holes))

Anyone experienced the same?

@justjoheinz
Copy link
Contributor

BTW, I tried the master branch, or which is the current working branch for the ts extensions?

@archaeron
Copy link
Member Author

typescript version 2.0.0 is really old I'm guessing that's why you're getting those errors) you shouldn't need to install it yourself though.
What platform are you testing this on? so that I can try it out too

This is the branch where I try to switch to https://github.com/meraymond2/idris-ide-client. This should streamline our code and we share the implementation of the idris parts with the vscode extension. My plan would be to cut a new version after we've successfully switched.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants