-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use idris-ide-client #251
base: master
Are you sure you want to change the base?
use idris-ide-client #251
Conversation
idris-ide-client doesn't handle ipkg files, so I started a project to parse them, so that we can reuse that part too between the atom and the vscode plugin: |
7c9dddd
to
f82e38f
Compare
could you test this out? :) |
f82e38f
to
e0fa42d
Compare
e0fa42d
to
134b947
Compare
I'll find some time at the beginning of next week. Glad to test. |
I'll check it out after work |
thank you! |
It's crashing in idris-ide-engine's replyHandler for me. Have to pin it down a bit more. |
@melted what OS and idris version are you on? |
Yes, I did npm install (well, after it failed because idris-ide-engine was missing). I used it on windows. I tested with both Idris 1.3.3 and Idris 2. I'll have some time to debug it tomorrow. |
It's really weird, the messages gets sliced up wrong. It connects alright, including parsing the reply. Then when it sends a command (say Open REPL) and it gets an answer And then it bombs the next time when |
Oh yeah, there's a stray newline in the buffer. |
idris2 is not yet supported by meraymond2/idris-ide-client but they are making good progress :) thanks for testing and reporting the issue on the other repo! I had only tested this on Linux |
@melted I updated to the newest version of the idris-ide-client, where the windows issue should be fixed now could you test it out again? :) |
Will do! |
I had been out of the loop for awhile. After needing to install a typescript peer dependency (I choose
Anyone experienced the same? |
BTW, I tried the master branch, or which is the current working branch for the ts extensions? |
typescript version 2.0.0 is really old I'm guessing that's why you're getting those errors) you shouldn't need to install it yourself though. This is the branch where I try to switch to https://github.com/meraymond2/idris-ide-client. This should streamline our code and we share the implementation of the idris parts with the vscode extension. My plan would be to cut a new version after we've successfully switched. |
Work in progress to replace our own ide client with this:
https://github.com/meraymond2/idris-ide-client