Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assets: update example.conf #709

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

assets: update example.conf #709

wants to merge 3 commits into from

Conversation

davc0n
Copy link
Contributor

@davc0n davc0n commented Mar 16, 2025

Includes examples from wiki with minor modifications. Date and time labels inspired by https://github.com/catppuccin/hyprlock

Aims to improve out-of-the-box experience and basic stuff reference.

Includes examples from wiki with minor modifications.
Date and time labels inspired by https://github.com/catppuccin/hyprlock

Aims to improve out-of-the-box experience and basic stuff reference.
Copy link
Collaborator

@PaideiaDilemma PaideiaDilemma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I like the idea of having a default config that looks good and is usable.

Additional things to discuss/improve:

  • dots spacing and their default animation. (My config feels a bit smoother. I have animation=inputFieldDots, 1, 2, linear)
  • pick one syntax to define colors? Not a big deal. Showing multiple different ways to specify colors is also ok, but I think declaring all with rgb(a)(r, g, b[, a]) is cleaner.

inner_color = rgba(0, 0, 0, 0.0) # no fill

outer_color = rgba(33ccffee) rgba(00ff99ee) 45deg
check_color = rgba(00ff99ee) rgba(ff6633ee) 120deg
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the check color could be improved. It's orange/red at the top of the input field which looks like it could mean "fail".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

those colors are meant to have a sort of transition effect it seems... took that from the wiki example iirc, tbh not sure how to obtain what you asked for (idc about colors and animation stuff).

Which values would you use?

@PaideiaDilemma
Copy link
Collaborator

@alba4k also adding you for your opinion on the looks, since I think you have a pretty config :)

@alba4k
Copy link
Contributor

alba4k commented Mar 17, 2025

@PaideiaDilemma ahah damn, thanks, that's a funny but nice reason to be added :)

I think this looks great! It also fits the theme of the default Hyprland configuration, which is good.

let's not include disable_loading_bar. I want to remove this setting at some point. Doesn't really do anything most configs, as assets usually load quickly.

Agree, I never even saw that loading bar (can't see it even if I lock my cpu at 400 mHz).

I think the check color could be improved. It's orange/red at the top of the input field which looks like it could mean "fail".

Also agree, something like a lighter yellow would probably be better, although I suppose the idea was having it half orange and half green (as to make the unclear state of "is it going to unlock?" obvious). What about

check_color = rgba(00ff99ee) rgba(ffee33ee) 120deg

I think it would be a good idea to add auth:fingerprint:enabled = true, as it is a great feature that most hyprlock alternatives do not have. Not sure if enabling it without a fingerprint reader causes issues, tho. Maybe it would also just make sense to have this be enabled by default, though.

@davc0n
Copy link
Contributor Author

davc0n commented Mar 17, 2025

@PaideiaDilemma

dots spacing and their default animation. (My config feels a bit smoother. I have animation=inputFieldDots, 1, 2, linear)

sure let me know what should be added, tbh idc about animations so I just picked whatever was in the previous example and kept that

pick one syntax to define colors? Not a big deal. Showing multiple different ways to specify colors is also ok, but I think declaring all with rgb(a)(r, g, b[, a]) is cleaner.

don't know which one is more convenient. Personally I would opt for the hexadecimal one, is more concise:

    inner_color = rgba(00000000) # no fill

    outer_color = rgba(33ccffee) rgba(00ff99ee) 45deg
    check_color = rgba(00ff99ee) rgba(ff6633ee) 120deg
    fail_color = rgba(ff6633ee) rgba(ff0066ee) 40deg

    font_color = rgba(8f8f8fff)

alternatively we could use the one you suggested:

    inner_color = rgba(0, 0, 0, 0.0) # no fill

    outer_color = rgba(51, 204, 255, 0.93) rgba(0, 255, 153, 0.93) 45deg
    check_color = rgba(0, 255, 153, 0.93) rgba(255, 102, 51, 0.93) 120deg
    fail_color = rgba(255, 102, 51, 0.93) rgba(255, 0, 102, 0.93) 40deg

    font_color = rgba(143, 143, 143, 1.0)

@alba4k

something like a lighter yellow would probably be better

the one you posted looks good, but if we opt for that the green part at the bottom should change to yellow too (smthing similar to the fail color which is entirely red)

I think it would be a good idea to add auth:fingerprint:enabled = true, as it is a great feature that most hyprlock alternatives do not have. Not sure if enabling it without a fingerprint reader causes issues, tho. Maybe it would also just make sense to have this be enabled by default, though.

dunno if can cause issues, by default is not enabled... eventually I'd keep it commented out

@alba4k
Copy link
Contributor

alba4k commented Mar 17, 2025

the one you posted looks good, but if we opt for that the green part at the bottom should change to yellow too (smthing similar to the fail color which is entirely red)

fail color is a gradient with red and orange, so not sure what you mean?

@davc0n
Copy link
Contributor Author

davc0n commented Mar 17, 2025

was talking about check_color, the one you posted is yellow and green, maybe we could replace the green part with a darker yellow or orange... otherwise if we want to keep the green for the current sort of transition effect, the current value looks more consistent imho

@PaideiaDilemma
Copy link
Collaborator

@alba4k @davc0n sorry was busy in the last two days.

I think it would be a good idea to add auth:fingerprint:enabled = true, as it is a great feature that most hyprlock alternatives do not have.

I like I that idea. I have it in some of the configs I test and besides an error in your logs it shouldn't really cause any issues.

Regarding check color.
I think what alba suggested already looks better. Although in that case I would swap the fail colors around.
Other options:
Just make it green, no gradient:

    check_color = rgba(00ff99ee) 120deg

Make check color be the exact colors in between outer and fail:

    check_color = rgba(b789ffee) rgba(c1c100ee) 120deg

Pick whatever you think looks best.

Color syntax wise, if we want to decide on one, I would go full decimal, because it is the easiest to understand for newbies. But there are also benefits in showcasing both formats, so let's just leave it mixed like it is now?

@alba4k
Copy link
Contributor

alba4k commented Mar 20, 2025

Just make it green, no gradient

mhhh no, I think that would make it confusing in case it fails, as it would seem to suggest that you were authenticated successfully

@PaideiaDilemma
Copy link
Collaborator

mhhh no, I think that would make it confusing in case it fails, as it would seem to suggest that you were authenticated successfully

Ok yeah you are 100% right.

@davc0n
Copy link
Contributor Author

davc0n commented Mar 20, 2025

But there are also benefits in showcasing both formats, so let's just leave it mixed like it is now?

Left it mixed.

Latest commit should solve most of the points, remaining stuff is animation and colors, let me know which values do you prefer for those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants