-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
assets: update example.conf #709
base: main
Are you sure you want to change the base?
Conversation
Includes examples from wiki with minor modifications. Date and time labels inspired by https://github.com/catppuccin/hyprlock Aims to improve out-of-the-box experience and basic stuff reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I like the idea of having a default config that looks good and is usable.
Additional things to discuss/improve:
- dots spacing and their default animation. (My config feels a bit smoother. I have
animation=inputFieldDots, 1, 2, linear
) - pick one syntax to define colors? Not a big deal. Showing multiple different ways to specify colors is also ok, but I think declaring all with
rgb(a)(r, g, b[, a])
is cleaner.
inner_color = rgba(0, 0, 0, 0.0) # no fill | ||
|
||
outer_color = rgba(33ccffee) rgba(00ff99ee) 45deg | ||
check_color = rgba(00ff99ee) rgba(ff6633ee) 120deg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the check color could be improved. It's orange/red at the top of the input field which looks like it could mean "fail".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
those colors are meant to have a sort of transition effect it seems... took that from the wiki example iirc, tbh not sure how to obtain what you asked for (idc about colors and animation stuff).
Which values would you use?
@alba4k also adding you for your opinion on the looks, since I think you have a pretty config :) |
@PaideiaDilemma ahah damn, thanks, that's a funny but nice reason to be added :) I think this looks great! It also fits the theme of the default Hyprland configuration, which is good.
Agree, I never even saw that loading bar (can't see it even if I lock my cpu at 400 mHz).
Also agree, something like a lighter yellow would probably be better, although I suppose the idea was having it half orange and half green (as to make the unclear state of "is it going to unlock?" obvious). What about
I think it would be a good idea to add |
sure let me know what should be added, tbh idc about animations so I just picked whatever was in the previous example and kept that
don't know which one is more convenient. Personally I would opt for the hexadecimal one, is more concise:
alternatively we could use the one you suggested:
the one you posted looks good, but if we opt for that the green part at the bottom should change to yellow too (smthing similar to the fail color which is entirely red)
dunno if can cause issues, by default is not enabled... eventually I'd keep it commented out |
fail color is a gradient with red and orange, so not sure what you mean? |
was talking about check_color, the one you posted is yellow and green, maybe we could replace the green part with a darker yellow or orange... otherwise if we want to keep the green for the current sort of transition effect, the current value looks more consistent imho |
@alba4k @davc0n sorry was busy in the last two days.
I like I that idea. I have it in some of the configs I test and besides an error in your logs it shouldn't really cause any issues. Regarding check color.
Make check color be the exact colors in between outer and fail:
Pick whatever you think looks best. Color syntax wise, if we want to decide on one, I would go full decimal, because it is the easiest to understand for newbies. But there are also benefits in showcasing both formats, so let's just leave it mixed like it is now? |
mhhh no, I think that would make it confusing in case it fails, as it would seem to suggest that you were authenticated successfully |
Ok yeah you are 100% right. |
Left it mixed. Latest commit should solve most of the points, remaining stuff is animation and colors, let me know which values do you prefer for those. |
Includes examples from wiki with minor modifications. Date and time labels inspired by https://github.com/catppuccin/hyprlock
Aims to improve out-of-the-box experience and basic stuff reference.