Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnd: misc changes #9652

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

dnd: misc changes #9652

wants to merge 2 commits into from

Conversation

nnyyxxxx
Copy link
Contributor

@nnyyxxxx nnyyxxxx commented Mar 17, 2025

positions the icon at the cursor hotspot which is recommended by the spec

and other misc changes taken out of #9564

see here:

https://wayland.app/protocols/wayland#wl_data_device

@nnyyxxxx nnyyxxxx changed the title dnd: some changes dnd: misc changes Mar 17, 2025
@nnyyxxxx nnyyxxxx marked this pull request as ready for review March 17, 2025 19:55
@vaxerski
Copy link
Member

?

@nnyyxxxx
Copy link
Contributor Author

nnyyxxxx commented Mar 17, 2025

?

wdym "?"

bro sends a cryptographic message with no context and then just dips 😭

@ikalco
Copy link
Contributor

ikalco commented Mar 17, 2025

@nnyyxxxx
Copy link
Contributor Author

@vaxerski
Copy link
Member

what if I pull a gnome here and say I dont like it

@nnyyxxxx
Copy link
Contributor Author

whats wrong with it 😭 its basically the same as before but more spec compliant + the icon is actually positioned correctly now

@vaxerski
Copy link
Member

ye I don't like the positioning though xD

@tannerellen
Copy link

tannerellen commented Mar 24, 2025

Honestly from a 3rd party perspective the current icon position on drag seems broken. It's too far removed from your cursor and my first thought was that it was a bug, but I never got around to submitting a bug report because I didn't bother to look into it, if it was hyprland or thunar specifically. I'm not aware of any interface guidelines that would call for the placement as it is now.

Also one nice thing about adopting standards is it takes away these small decisions. It's why we use code formatters. It takes away all these little decisions that we could disagree on. I don't think adopting standards should be easily dismissed.

If you are seriously not considering this merge request at least take a poll or something on discord.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants