keybinds: add all flag to closewindow dispatcher #9602
+106
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaxerski
reviewed
Mar 12, 2025
src/managers/KeybindManager.cpp
Outdated
| if (!w->m_bIsMapped || (w->isHidden() && !g_pLayoutManager->getCurrentLayout()->isWindowReachable(w))) | ||
| continue; | ||
|
|
||
| g_pCompositor->m_vWindows = {w}; |
There was a problem hiding this comment.
what the fuck is this. Just extract the matching logic to CWindow just like CWorkspace has matchesStaticSelector and use that. What the f
There was a problem hiding this comment.
what the fuck is this. Just extract the matching logic to CWindow just like CWorkspace has
matchesStaticSelectorand use that. What the f
meh.... current approach is good... if it works it works
There was a problem hiding this comment.
what the fuck is this. Just extract the matching logic to CWindow just like CWorkspace has
matchesStaticSelectorand use that. What the f
wouldn't this just dupe code more tho
nnyyxxxx
force-pushed
the
patch-3
branch
2 times, most recently
from
80b5ff0 to
550e456
Compare
nnyyxxxx
changed the title
|
well now you should make |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9243
example:
hyprctl dispatch closewindow all:class:Alacritty