Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not override GITHUB_TOKEN env var #30

Merged
merged 1 commit into from
Jan 30, 2025
Merged

fix: Do not override GITHUB_TOKEN env var #30

merged 1 commit into from
Jan 30, 2025

Conversation

hustcer
Copy link
Owner

@hustcer hustcer commented Jan 30, 2025

fix: Do not override GITHUB_TOKEN env var, fixes #27

Copy link

Issues Identified:

  1. README.md - Typo Correction:

    • The change in README.md corrects a typo where system prompt was incorrectly used instead of user prompt. This is a good change as it aligns the documentation with the intended meaning.
  2. review.nu - Unnecessary Environment Variable Assignment:

    • The line $env.GITHUB_TOKEN = $gh_token | default $env.GITHUB_TOKEN? was removed. This could be problematic if the code relies on $env.GITHUB_TOKEN being set elsewhere. If $gh_token is expected to be the primary source for the GitHub token, ensure that it is properly handled in the rest of the code.

Recommendations:

  1. README.md:

    • No further action is needed for README.md as the change is correct and improves clarity.
  2. review.nu:

    • Ensure Token Handling: Verify that $gh_token is properly passed and used throughout the script. If $env.GITHUB_TOKEN is still required elsewhere, ensure it is set appropriately.
    • Documentation Update: If the removal of the environment variable assignment is intentional, update the documentation to reflect that $gh_token should be used directly instead of relying on $env.GITHUB_TOKEN.

Summary:

  • The changes in README.md are correct and improve clarity.
  • The removal of the environment variable assignment in review.nu requires careful consideration to ensure it does not break functionality. Ensure that $gh_token is properly handled and documented.

@hustcer hustcer merged commit b527650 into main Jan 30, 2025
1 check passed
@github-actions github-actions bot added this to the v1.1.0 milestone Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't override $env.GITHUB_TOKEN var
1 participant