get pty by tmux command and close pane when gdb exit #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grazfather
reviewed
Sep 11, 2022
gef.py
Outdated
| old_ptses = set(os.listdir("/dev/pts")) | ||
| gdb.execute(f"! {tmux} split-window -h 'clear ; cat'") | ||
|
|
||
| pane_info = subprocess.check_output(["tmux", "splitw", "-h",'-F#{session_name}:#{window_index}.#{pane_index}-#{pane_tty}', "-P"]).decode().strip().split("-") |
There was a problem hiding this comment.
this should be tmux not "tmux", and double quotes around the long arg.
There was a problem hiding this comment.
double quotes will not work here
gef.py
Outdated
| pane_info = subprocess.check_output(["tmux", "splitw", "-h",'-F#{session_name}:#{window_index}.#{pane_index}-#{pane_tty}', "-P"]).decode().strip().split("-") | ||
| pane = pane_info[0] | ||
| pty = pane_info[1] | ||
| atexit.register(lambda : os.system(f"{tmux} kill-pane -t {pane}")) |
There was a problem hiding this comment.
Why not use subprocess here?
There was a problem hiding this comment.
use subprocess.run now
RoderickChan
force-pushed
the
dev
branch
2 times, most recently
from
dd9edbf to
76461eb
Compare
Grazfather
reviewed
Sep 27, 2022
gef.py
Outdated
| pty = pane_info[1] | ||
| atexit.register(lambda : subprocess.run([tmux, "kill-pane", "-t", pane])) | ||
|
|
||
| gdb.execute(f"! {tmux} send-keys -t {pane} 'clear;sleep infinity' C-m") |
There was a problem hiding this comment.
Can you add a comment explaining why you need these keys to be sent?
There was a problem hiding this comment.
Can you add a comment explaining why you need these keys to be sent?
okay, I add a comment and still use cat.
Signed-off-by: roderick <[email protected]>
Grazfather
approved these changes
Sep 29, 2022
hugsy
reviewed
Sep 29, 2022
Co-authored-by: crazy hugsy <[email protected]>
hugsy
approved these changes
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: roderick [email protected]
Description/Motivation/Screenshots
Sometimes, the old method
list(new_ptses - old_ptses)[0]cannot get the right pty while meeting other tmux-pty operations at the same time. And it's better to kill the pane generated by tmux after quitting gdb.Against which architecture was this tested ?
"Tested" indicates that the PR works and the unit test (i.e.
make test) run passes without issue.Checklist
devbranch, notmain.