Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean-up & refactors; enabling some tests; specializing Path functions #987

Merged
merged 66 commits into from
Oct 14, 2021
Merged

clean-up & refactors; enabling some tests; specializing Path functions #987

merged 66 commits into from
Oct 14, 2021

Conversation

Anton-Latukha
Copy link
Collaborator

@Anton-Latukha Anton-Latukha commented Oct 11, 2021 •
edited
Loading

Specialization of former FilePath functions to Path happens mainly to:

  1. Prune String from code as much as possible and to maximally avoid conversions in the end.
  2. To have typesafe code (I/somebody still should remove Monoid for Path).
  3. Main reason: further to have an easy decision making how to control & process Paths and to have breather migration to path package (probably), which would make it even more realistic & typesafe code.

@Anton-Latukha
Exec: refactor
8162670
@Anton-Latukha
Builtins: refactor
9cd97db
@Anton-Latukha
treewide: m refactors
a681e6e
@Anton-Latukha
Eval: attrSetAlter: refactor
c11c3f1 
If values were (Pos, Attrs) - a lot of code would've been easier and optimized.
Shrinked the recursion loop, only 3 args were needed for recursion.
@Anton-Latukha
Builtins: splitDrvName: refactor
db18de0
@Anton-Latukha
Copy link
Collaborator Author

You are right.

layus
layus reviewed Oct 13, 2021
View reviewed changes
@Anton-Latukha Anton-Latukha marked this pull request as ready for review October 14, 2021 12:28
@Anton-Latukha Anton-Latukha merged commit 0e13db9 into master Oct 14, 2021
@Anton-Latukha Anton-Latukha deleted the 2021-09-03-upds branch October 14, 2021 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@layus layus layus left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Anton-Latukha @layus