VarName type boundary; flip {NVSetF, NSelect}; upd AttrSet; add PositionSet; coerce #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anton-Latukha
force-pushed
the
2021-07-15-hlint
branch
from
dc79b6a to
5a97223
Compare
Anton-Latukha
force-pushed
the
2021-07-15-hlint
branch
2 times, most recently
from
199f6c0 to
530cbae
Compare
Future would rehash this logic into more consice form.
M src/Nix/Convert.hs
Anton-Latukha
force-pushed
the
2021-07-15-hlint
branch
from
530cbae to
5f096dd
Compare
This is obviously a big change. Before this units of data in expressions were undistinquisable from Text. Not VarName is there to mark something as an abstraction, some argument that has/can have/can be binded a value. Went through the whole project & established the boundary. The boundary stops entering the Derivations (their file format puts everything in "", so they are left as text), CLI Options & Executable. Maybe `KeyMap` datatype that is in utils should be removed, at least the `Keymap SourcePos` should be replaced with `PosSet`. Now the code would be more intuitive & would read better.
Anton-Latukha
force-pushed
the
2021-07-15-hlint
branch
from
6d36c9e to
a65d6bb
Compare
The proper argument order.
… arg This allows to reuse `Nothing` & `Just` logic between uses. This also leads to more streamlined code.
Anton-Latukha
changed the title
Anton-Latukha
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.