Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keenpad V1 #610

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Keenpad V1 #610

wants to merge 17 commits into from

Conversation

keenwarice
Copy link

Ready to submit your project? Nice job! Hopefully you've read the submission guidelines. If not, make sure to read them first.

Check off the following to let the reviewers know you've done everything:
[✔] I HAVE RAN DRC ON MY DESIGN WITH ZERO ERRORS (Silkscreen errors are okay)
[✔] I HAVE BRANDED ALL MY PARTS (PCB, CASE) WITH MY HACKPAD'S NAME
[✔] I HAVE MADE SURE MY 3D PRINTED PARTS DO NOT REQUIRE SUPPORTS (Text branding overhang is okay)
[✔] I HAVE MADE SURE TO INCLUDE TOLERANCES (0.25mm)
[✔] MY HACKPAD'S PCB IS UNDER 100mm x 100mm, I DO NOT HAVE MORE THAN 16X SWITCHES, 2X ROTARY ENCODERS, 1X OLED, 16X LEDS.
[✔] IN MY FOLDER, THERE IS A README.MD FILE THAT CONTAINS THE FOLLOWING INFORMATION:

  • Full render including all the parts
  • A few sentences about the inspiration and challenges
  • BOM
  • Photos of the Schematic, PCB, and case

If you're unsure about the format, make sure to check out this example and follow the format there.

If this PR isn't a submission, that's okay too! Please remove the above boxes and explain what the pull request is for! If there's anything about this PR template that seems confusing, send a message in #hackpad in slack!

Copy link

vercel bot commented Feb 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hackpad ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2025 11:07pm

@keenwarice keenwarice marked this pull request as ready for review February 21, 2025 05:54
@keenwarice keenwarice marked this pull request as draft February 21, 2025 05:58
@lukasn9
Copy link
Contributor

lukasn9 commented Mar 8, 2025

The schematic and stuff looks good, but you should also include the images in the readme.
It's simple, just add this to the readme:

Schematic PCB Case
![image](link to the raw file, see other images to see how the link looks) image image

@lukasn9
Copy link
Contributor

lukasn9 commented Mar 9, 2025

Looks good, I approve! Here's my own approved Hackpad: #370
Just one recommendation, considering adding the images in README using this code, it should be more readable:

Schematic            |  PCB         |   Case
:-------------------------:|:-------------------------:|:-------------------------:|
![image](link to raw img)    |  ![image](link to raw img)  | ![image](link to raw img)

Copy link
Contributor

@danieliscrazy danieliscrazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, this gets my approval! My PR is #590

@keenwarice
Copy link
Author

Looks good, I approve! Here's my own approved Hackpad: #370

Just one recommendation, considering adding the images in README using this code, it should be more readable:


Schematic            |  PCB         |   Case

:-------------------------:|:-------------------------:|:-------------------------:|

![image](link to raw img)    |  ![image](link to raw img)  | ![image](link to raw img)

@lukasn9 Done!

@lukasn9
Copy link
Contributor

lukasn9 commented Mar 12, 2025

Great! @qcoral it's ready to be merged

@keenwarice
Copy link
Author

@qcoral i think this is ready to merge, 2 people have already approved it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants