-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade flask-bootstrap to bootstrap-flask #41
Conversation
Thanks! The existing web app has worked quite well though and I liked the look. I also wasn't planning to make the webapp installs optional, it was my intention to just have it in the install and have it available by default. I'll try to get back to this and adjust the appearance at some point. |
Sorry I have a bad habit of including several things in the same PR. I think it might be good to split up these three things into different PR's then evaluate separately. Having the flask installation be separate would definitely be good for me because I'm getting conflicts between The entrypoints thing is cool, but totally cosmetic and the |
I'm still a bit conflicted about this because we have several other services that use |
Also in relation to #43, I wonder if there is a way to separate the original JSON REST API (which should be available in every default install) from the form-based GUI (which should be running on the deployed grounding.indra.bio but doesn't necessarily need to be installed when gilda is used programmatically). Then switching over to |
I think this could be accomplished by using Blueprints and wrapping them in functions to hide imports. That could be a separate PR - let me know if you want me to give it a shot |
For the time being I will close this because other related apps depend on |
This PR does the following:
switches the outdated/not maintained
flask-bootstrap
package tobootstrap-flask
. This updates from Bootstrap 3 to Bootstrap 4, so some of the elements needed to be renamed as well as modifications to the base package. Unfortunately, this leaves the diff on the HTML quite large, but all of the text and functionality is exactly the same.This PR also makes the web application requirements optional in case somebody doesn't need web functionality or is worried about conflicting(These changes were moved to Make flask requirement optional #43)flask-bootstrap
andbootstrap-flask
.Adds an entrypoint so the web app can be run simply with(These changes were moved to Add Gilda CLI and entrypoints #42)gilda
from the command lineThe two pages now look like this:
Home
Results