Move dump_terms() #117
Merged
Move dump_terms() #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because this function is in generate_terms.py, it means you need to have indra installed to reuse this function. This PR moves dump_terms() into term.py, which is always available. Since it's still imported into generate_terms.py, this should have no backwards compatibility issues, even if someone is doing from `gilda.generate_terms import dump_terms`
bgyori
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because this function is in generate_terms.py, it means you need to have indra installed to reuse this function. This PR moves dump_terms() into term.py, which is always available. Since it's still imported into generate_terms.py, this should have no backwards compatibility issues, even if someone is doing from
gilda.generate_terms import dump_terms