Move filter_out_duplicates function
#103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR moves the `filter_out_duplicates()` frunction from the `gilda.generate_terms` module to `gilda.term` module. This makes it possible for `biomappings` to import this function without installing `indra`. Since `filter_out_duplicates` is still imported by `gilda.generated_terms`, it is still available in the namespace and therefore no downstream code needs to be modified.
bgyori
force-pushed
the
move-filter-duplicates
branch
from
30cb3b0 to
b568cbb
Compare
cthoyt
commented
Nov 17, 2022
| @@ -9,7 +9,7 @@ | |||
| "filter_out_duplicates", | |||
| ] | |||
|
|
|||
| logger = logging.getLogger("gilda.term") | |||
| logger = logging.getLogger(__name__) | |||
There was a problem hiding this comment.
I typically do this but noticed it wasn't the case in the other module, maybe we can normalize that one now too
bgyori
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the
filter_out_duplicates()frunction from thegilda.generate_termsmodule togilda.termmodule.This makes it possible for
biomappingsto import this function without installingindra.Since
filter_out_duplicatesis still imported bygilda.generated_terms, it is still available in the namespace and therefore no downstream code needs to be modified.