Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent Stripe Express Switch for One Time Payments #6824

Merged
merged 4 commits into from
Mar 10, 2025

Conversation

tjmw
Copy link
Member

@tjmw tjmw commented Mar 4, 2025

What are you doing in this PR?

Before:

  • Stripe express switch controlling the frontend
  • Separate Stripe Apple pay and Stripe payment request switches
    controlling the backend
  • Different combinations of these switches don't make sense, they either
    need to be all enabled or all disabled

After:

  • One single switch (Stripe express) controlling the front end and the
    back end

Trello Card

Why are you doing this?

Consistency with switches should make things less error prone.

How to test

I've deployed the payment-api project to CODE and verified that the Stripe Apple Pay and Stripe Payment Request Button switches no longer have any effect. I turned them both off via CODE RRCP and was still able to put through an Apple Pay transaction.

TODO: Deploy support-frontend to CODE and verify all's well, just in case. Done ✅

How can we measure success?

Have we considered potential risks?

Accessibility test checklist

Screenshots

tjmw added 2 commits March 4, 2025 10:39
Before:
* Stripe express switch controlling the frontend
* Separate Stripe Apple pay and Stripe payment request buttons
  controlling the backend
* Different combinations of these switches don't make sense, they either
  need to be all enabled or all disabled

After:
* One single switch (Stripe express) controlling the front end and the
  back end
Copy link
Contributor

github-actions bot commented Mar 4, 2025

Size Change: 0 B

Total Size: 1.94 MB

ℹ️ View Unchanged
Filename Size
./public/compiled-assets/javascripts/[countryGroupId]/events/router.js 92.3 kB
./public/compiled-assets/javascripts/[countryGroupId]/router.js 97 kB
./public/compiled-assets/javascripts/ausMomentMap.js 108 kB
./public/compiled-assets/javascripts/contributionsRedirectStyles.js 20 B
./public/compiled-assets/javascripts/digitalSubscriptionLandingPage.js 225 kB
./public/compiled-assets/javascripts/downForMaintenancePage.js 69.1 kB
./public/compiled-assets/javascripts/error404Page.js 69.1 kB
./public/compiled-assets/javascripts/error500Page.js 69 kB
./public/compiled-assets/javascripts/favicons.js 617 B
./public/compiled-assets/javascripts/paperSubscriptionCheckoutPage.js 165 kB
./public/compiled-assets/javascripts/paperSubscriptionLandingPage.js 89.6 kB
./public/compiled-assets/javascripts/payPalErrorPage.js 67.6 kB
./public/compiled-assets/javascripts/payPalErrorPageStyles.js 20 B
./public/compiled-assets/javascripts/promotionTerms.js 75.7 kB
./public/compiled-assets/javascripts/subscriptionsLandingPage.js 80.2 kB
./public/compiled-assets/javascripts/subscriptionsRedemptionPage.js 120 kB
./public/compiled-assets/javascripts/unsupportedBrowserStyles.js 20 B
./public/compiled-assets/javascripts/weeklySubscriptionCheckoutPage.js 162 kB
./public/compiled-assets/javascripts/weeklySubscriptionLandingPage.js 89.8 kB
./public/compiled-assets/webpack/109.js 26 kB
./public/compiled-assets/webpack/114.js 12.2 kB
./public/compiled-assets/webpack/127.js 3.53 kB
./public/compiled-assets/webpack/136.js 2.17 kB
./public/compiled-assets/webpack/163.js 8.9 kB
./public/compiled-assets/webpack/172.js 38.1 kB
./public/compiled-assets/webpack/187.js 20.7 kB
./public/compiled-assets/webpack/192.js 5.71 kB
./public/compiled-assets/webpack/276.js 4.39 kB
./public/compiled-assets/webpack/344.js 2 kB
./public/compiled-assets/webpack/445.js 6.96 kB
./public/compiled-assets/webpack/492.js 7.58 kB
./public/compiled-assets/webpack/706.js 107 kB
./public/compiled-assets/webpack/975.js 24 kB
./public/compiled-assets/webpack/checkout.js 17.5 kB
./public/compiled-assets/webpack/GuardianAdLiteLanding.js 8.29 kB
./public/compiled-assets/webpack/LandingPage.js 15.4 kB
./public/compiled-assets/webpack/oneTimeCheckout.js 6.2 kB
./public/compiled-assets/webpack/ThankYou.js 44.5 kB

compressed-size-action

@tjmw tjmw merged commit cee6f28 into main Mar 10, 2025
19 checks passed
@tjmw tjmw deleted the tw/consistent-stripe-express-switch branch March 10, 2025 09:30
@prout-bot
Copy link

Seen on PROD (merged by @tjmw 8 minutes and 50 seconds ago)

Sentry Release: support-client-side, support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants