Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/control: update package description to clarify sources.list situation #19

Closed
wants to merge 1 commit into from

Conversation

mika
Copy link
Member

@mika mika commented Feb 28, 2025

We nowadays ship the file /usr/share/grml-keyring/grml.sources with /etc/apt/sources.list.d/grml.sources as symlink pointing to that file. So when someone installs the grml-keyring package, they might not be aware that also the Grml repositories are enabled by default, Clarify this through the package description.

Closes: #18

We nowadays ship the file /usr/share/grml-keyring/grml.sources with
/etc/apt/sources.list.d/grml.sources as symlink pointing to that file.
So when someone installs the grml-keyring package, they might not be
aware that also the Grml repositories are enabled by default, Clarify
this through the package description.

Closes: #18
@mika mika requested review from zeha and jkirk February 28, 2025 12:39
@akorn
Copy link

akorn commented Feb 28, 2025

Instead of clarifying it in the description, please don't install the /etc/apt/sources.list.d/ symlink automatically. The admin can do that if they want.

Installing the symlink broke unattended-upgrades (by breaking apt) on all my systems, because I had my own grml.list with a signed-by the pointed to /etc/apt/keyrings/grml.gpg (which I had put there).

In this situation, with the new grml.sources symlink in place, apt fails with:

E: Conflicting values set for option Signed-By regarding source http://deb.grml.org/ grml-stable: /etc/apt/keyrings/grml.gpg != /usr/share/keyrings/grml-archive-keyring.pgp
E: The list of sources could not be read.

@mika
Copy link
Member Author

mika commented Feb 28, 2025

Thanks for your feedback, we plan to split the grml.sources file into a separate grml-apt-source binary package, which then will be a Recommends inside grml-keyring package only and try to get this change through Debian's NEW.

@akorn
Copy link

akorn commented Feb 28, 2025

Thanks for your feedback, we plan to split the grml.sources file into a separate grml-apt-source binary package, which then will be a Recommends inside grml-keyring package only and try to get this change through Debian's NEW.

Why Recommends and not Suggests?

The grml-apt-source package Depends on the keyring (and thus the grml-keyring package), that's clear; but they keyring is usable and useful without the grml-apt-source package.

apt by default installs Recommended packages. Is it appropriate to enable the grml repository by default on all systems that just want the grml keyring?

@crpb
Copy link
Contributor

crpb commented Mar 1, 2025

fwiw... but yeah.. NEW is a b* :P.
master...crpb:grml-debian-keyring:master

@mika
Copy link
Member Author

mika commented Mar 1, 2025

fwiw... but yeah.. NEW is a b* :P. master...crpb:grml-debian-keyring:master

@crpb more than happy to get your PR! :)

@crpb crpb mentioned this pull request Mar 1, 2025
@mika
Copy link
Member Author

mika commented Mar 10, 2025

Replaced by #21

@mika mika closed this Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package description is misleading
4 participants