Minio : pass size argument

[vviers]

Fixes #1488

Looking at the MinIO.js client's code for putObject, it looks like passing the size argument lets it be clever about whether to perform an upload in one part or as a multi-part.

I also threw some new comments in the codebase that were usefull to me when reading the code. Can revert or shove them in a separate PR if you'd prefer.

[paulfitz]

@vviers passing size is a good improvement. The comments are welcome. Please ping when ready for review.

(ccing also @Spoffy since he is touching same interface in a parallel PR but everything looks compatible)

[vviers]

@paulfitz @Spoffy an initial review would be helpful :)

I'm looking into adding tests but I'm not super familiar with the test codebase in grist, let alone testing in JS, so any pointer would be useful 🙂

[vviers]

I tried to add the same behavior to the ExternalStorageAttachmentStore's upload method so that I could add a test here before realizing that there was no reliable way to know the size of the the readable stream coming in, duh 🙃

[vviers]

I tried to add a test to https://github.com/gristlabs/grist-core/blob/main/test/server/lib/HostedStorageManager.ts and failed miserably, this JS code is a bit above my paygrade 😶 help appreciated here !

[vviers]

I am fairly confident that the failed CI run is unrelated to my changes

[fflorent]

Also I wonder if whether should add tests after these changes.

[fflorent]

Ok, about the second comment, but what about the first one ?

[vviers]

Ok, about the second comment, but what about the first one ?

Done ✅

[paulfitz]

Thanks @vviers ! I think existing tests cover this, I'd have expected failures if the introduction of size caused an issue.