Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: More readable Document settings #1376

Merged
merged 7 commits into from
Mar 17, 2025
Merged

feat: More readable Document settings #1376

merged 7 commits into from
Mar 17, 2025

Conversation

hexaltation
Copy link
Collaborator

Partially fixes #1289

Context

#1015 mockup is completed with some Document settings page enhancement.

Proposed solution

The first proposal was in PR #1181.
As suggested by @berhalak It was removed from functional code to be done in this separate PR.

This PR only enroll Document setting page enhancements.

Two other PRs will propose:

  • Check boxes component enhancements
  • Modal component Enhancements

Related issues

#1015
#1289

Has this been tested?

  • 🙅 no, because this is not relevant here

@berhalak berhalak self-assigned this Jan 21, 2025
@berhalak
Copy link
Contributor

Take a look at this screenshot:
image

The currency's description is slightly moved to the right. It happens when I'm making my screen narrower. It works ok on main branch.

@hexaltation hexaltation force-pushed the feat-ux-document-settings branch from 780b0cc to e5cf459 Compare January 29, 2025 17:22
@hexaltation
Copy link
Collaborator Author

hexaltation commented Jan 30, 2025 •
edited
Loading

The currency's description is slightly moved to the right. It happens when I'm making my screen narrower. It works ok on main branch.

Hello @berhalak

After some jobs jobs, thing are aligned with smaller screen.

Capture d’écran 2025-01-30 à 15 10 58

I've fixed DocumentId input width in my last commit, after screenshots.

@hexaltation hexaltation added the preview Launch preview deployment of this PR label Jan 30, 2025
@hexaltation hexaltation requested a review from berhalak January 30, 2025 14:20
@github-actions GitHub Actions
Copy link
Contributor

Deployed commit e5cf4595f628574fb39ff2f22eb881190494de78 as https://grist-hexaltation-grist-core-feat-ux-document-settings.fly.dev (until 2025-03-01T14:25:24.111Z)

@github-actions GitHub Actions
Copy link
Contributor

Deployed commit 287a44f88b9382b5ebb2185900fd553b03f103d5 as https://grist-hexaltation-grist-core-feat-ux-document-settings.fly.dev (until 2025-03-01T14:44:41.980Z)

berhalak
berhalak reviewed Feb 5, 2025
View reviewed changes
app/client/ui/DocumentSettings.ts Outdated
@@ -162,7 +162,7 @@ export class DocSettingsPage extends Disposable {
}) : null,
]),

dom.create(AdminSection, t('API'), [
dom.create(cssAdminSection, t('API'), [
Copy link
Contributor

@berhalak berhalak Feb 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you take a look at AdminPanel.ts ? It also uses those styles, maybe we can just update the base component, without wrapping it into cssAdminSection. The goal was to have those two pages (DocumentSettings and AdminPanel) look very similar.

@hexaltation hexaltation force-pushed the feat-ux-document-settings branch from 287a44f to cc98cff Compare February 18, 2025 15:01
@github-actions GitHub Actions
Copy link
Contributor

Deployed commit cc98cffc6948817899dd740cfea5b8f19a61b7ae as https://grist-hexaltation-grist-core-feat-ux-document-settings.fly.dev (until 2025-03-20T15:06:44.946Z)

@hexaltation hexaltation force-pushed the feat-ux-document-settings branch from cc98cff to b49b0da Compare February 18, 2025 15:13
@hexaltation
Copy link
Collaborator Author

b49b0da
breaks most adminPanel's sections third element alignment.
I'll wait for a point with @lusebille to verify what it's wanted for those components before making further changes.

@github-actions GitHub Actions
Copy link
Contributor

Deployed commit b49b0da7670cce9e4e3fe2c08c496945e93f0a24 as https://grist-hexaltation-grist-core-feat-ux-document-settings.fly.dev (until 2025-03-20T15:18:24.656Z)

@hexaltation hexaltation force-pushed the feat-ux-document-settings branch from b49b0da to 8c5ff36 Compare February 18, 2025 15:35
@github-actions GitHub Actions
Copy link
Contributor

Deployed commit 8c5ff36dd2c279f23426e4d219728e8d38a0a957 as https://grist-hexaltation-grist-core-feat-ux-document-settings.fly.dev (until 2025-03-20T15:40:39.971Z)

@lusebille
Copy link
Collaborator

@hexaltation About alignments, idea will be to align button everything on the right side, and keep full wide only for fields / dropdown (so buttons size will fit to content), actually they're sont items on the left, some on the right, some center-aligned ( see joined screen)
Capture d’écran 2025-02-26 à 10 46 31

@berhalak
Copy link
Contributor

The attachments UI is now to narrow:
image

@hexaltation hexaltation force-pushed the feat-ux-document-settings branch from 8c5ff36 to c6641c1 Compare March 6, 2025 14:38
@hexaltation hexaltation requested a review from fflorent March 6, 2025 14:39
@hexaltation hexaltation requested a review from berhalak March 6, 2025 14:51
@hexaltation hexaltation force-pushed the feat-ux-document-settings branch from c6641c1 to 9de90e3 Compare March 7, 2025 07:24
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2025

Deployed commit 9de90e3f556b27fbc1e739dd9ae54833f7fea5b3 as https://grist-hexaltation-grist-core-feat-ux-document-settings.fly.dev (until 2025-04-06T07:29:23.168Z)

@hexaltation hexaltation force-pushed the feat-ux-document-settings branch from 9de90e3 to e81e4c0 Compare March 11, 2025 08:13
@github-actions GitHub Actions
Copy link
Contributor

Deployed commit e81e4c09b572633a82694d9a41cc4d267303fa3a as https://grist-hexaltation-grist-core-feat-ux-document-settings.fly.dev (until 2025-04-10T08:18:46.501Z)

@hexaltation hexaltation force-pushed the feat-ux-document-settings branch 2 times, most recently from 1ae46b5 to fe62a08 Compare March 11, 2025 16:44
@github-actions GitHub Actions
Copy link
Contributor

Deployed commit fe62a08085c3ad959bdbbd5ba7691eb899fa11b5 as https://grist-hexaltation-grist-core-feat-ux-document-settings.fly.dev (until 2025-04-10T16:49:34.176Z)

berhalak
berhalak requested changes Mar 14, 2025
View reviewed changes
Copy link
Contributor

@berhalak berhalak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you align this checkbox as other to the right?

Current:
image

Previous:
image

@hexaltation hexaltation force-pushed the feat-ux-document-settings branch from fe62a08 to 1ecaccb Compare March 17, 2025 10:02
@github-actions GitHub Actions
Copy link
Contributor

Deployed commit 1ecaccb1b54001926911d9d7e31bb945eb31afdb as https://grist-hexaltation-grist-core-feat-ux-document-settings.fly.dev (until 2025-04-16T10:07:25.716Z)

@hexaltation
fix: admin panel updates toggle alignment
29abbea 
requested changes leads to a rework of updates components
To be able to have the proper alignment
@github-actions GitHub Actions
Copy link
Contributor

Deployed commit 29abbeac9af31925209486ce06d97dc8bb166f31 as https://grist-hexaltation-grist-core-feat-ux-document-settings.fly.dev (until 2025-04-16T15:02:34.706Z)

berhalak
berhalak approved these changes Mar 17, 2025
View reviewed changes
Copy link
Contributor

@berhalak berhalak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hexaltation

@berhalak berhalak merged commit a0447cc into gristlabs:main Mar 17, 2025
10 of 12 checks passed
@paulfitz
Copy link
Member

@hexaltation @berhalak this looks to have broken main.

@berhalak berhalak mentioned this pull request Mar 17, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fflorent fflorent fflorent approved these changes

@berhalak berhalak berhalak approved these changes

Assignees

@berhalak berhalak

Labels
-UX/UI gouv.fr preview Launch preview deployment of this PR
Projects
French administration Board
Archived in project
Grist UI/UX
Status: To Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Styling changes linked to document conversion
5 participants
@hexaltation @berhalak @lusebille @paulfitz @fflorent