task: add warning log for double submissions #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luca-gr4vy
added
patch
luca-gr4vy
commented
Mar 13, 2025
| @@ -26,7 +26,7 @@ jobs: | |||
| node-version: ${{ matrix.node-version }} | |||
|
|
|||
| - name: Cache node modules | |||
| uses: actions/cache@v1 | |||
| uses: actions/cache@v4 | |||
There was a problem hiding this comment.
To fix the v1 deprecation issue
douglaseggleton
approved these changes
Mar 13, 2025
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a warning log if Embed is submitted more than once in quick succession so that merchants are aware of potential issues related to a double submission (mainly wallets creating two sessions and throwing
Page already has an active payment session.)Ticket: https://gr4vy.atlassian.net/browse/TA-10323
Screenshots:
Checklist
yarn lintto make sure my changes pass all testsyarn testto make sure my changes pass all lintersmainbranchmain(e.g.releaseandpatch)Contribution guidelines
For contribution guidelines, styleguide, and other helpful information please
see the
CONTRIBUTING.mdfile in the root of this project.