feat: Add Session Module 3 #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #449 +/- ##
=======================================
Coverage 71.61% 71.61%
=======================================
Files 167 168 +1
Lines 10134 10176 +42
=======================================
+ Hits 7257 7288 +31
- Misses 2317 2324 +7
- Partials 560 564 +4 ☔ View full report in Codecov by Sentry. |
hwbrzzl
reviewed
Apr 1, 2024
session/middleware/start_session.go
Outdated
| } | ||
|
|
||
| // Retrieve session driver | ||
| d, err := session.Facade.Driver() |
There was a problem hiding this comment.
And add the judgment:
Suggested change
| d, err := session.Facade.Driver() | |
| driver, err := session.Facade.Driver() |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
kkumar-gcc
added a commit
that referenced
this pull request
Aug 4, 2024
* remove contentType from stream method * chore: update mocks * add ResponseStatus in the stream * chore: update mocks --------- Co-authored-by: kkumar-gcc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: goravel/goravel#357
Related PR: #428, #436
📑 Description
add
start_sessionmiddleware✅ Checks