Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(main.go): correct gop.Project usage and add build step to CI tests #44

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

aofei
Copy link
Member

@aofei aofei commented Mar 10, 2025

No description provided.

Signed-off-by: Aofei Sheng <[email protected]>
@aofei aofei requested a review from Copilot March 10, 2025 10:32

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR corrects the usage of gop.Project in main.go by updating the server initialization and file conversion logic, and it adds a new build step for WASM in the CI workflow.

  • Update server initialization to use gop.NewProject with the appropriate parameters.
  • Change the conversion function to return a pointer to vfs.MapFileImpl instead of a struct value.
  • Add a new "Build WASM" step in the CI configuration.

Reviewed Changes

File Description
main.go Updates server initialization and file conversion from MapFile to MapFileImpl.
.github/workflows/go.yml Adds a new CI step to build WASM using build.sh.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

main.go:121

  • Ensure that changing the MapFile construction to a pointer of MapFileImpl is consistent with downstream code expecting vfs.MapFile. Verify that this change does not introduce nil pointer issues in parts of the codebase that use these files.
result[key] = &vfs.MapFileImpl{

.github/workflows/go.yml:28

  • Verify that the build.sh script exists and has executable permissions so that the new WASM build step in CI does not fail.
- name: Build WASM
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.30%. Comparing base (63a27d9) to head (98e9550).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #44   +/-   ##
=======================================
  Coverage   65.30%   65.30%           
=======================================
  Files          38       38           
  Lines        5761     5761           
=======================================
  Hits         3762     3762           
  Misses       1758     1758           
  Partials      241      241           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xushiwei xushiwei merged commit 504ee64 into goplus:main Mar 10, 2025
5 checks passed
@aofei aofei deleted the main.go branch March 10, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants