Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Input System Package #24

Closed
wants to merge 4 commits into from

Conversation

mtschoen
Copy link

This PR is a companion to the main fix which is made in the native plugin code. Thankfully, the fix is very simple! 🥳

This contains some optional changes for the plugin to add a specific DeviceLayout for the Cardboard HMD. The primary benefit of this is to allow users to target bindings directly at Cardboard devices in case they have a need to differentiate it from other types of HMDs.

To be clear, the only thing needed to enable HMD tracking with the new input system is the change to the native plugin code. I'd still recommend using the extra C# code since it completes the steps described by the XR SDK documentation. Anyone using this project as an example will benefit from seeing how to implement device layouts.

Add InputLayoutLoader class to register input layouts for input system package;
Add sample scenes with input system TrackedPoseDriver
@arilow arilow requested review from chaosemer and removed request for chaosemer April 27, 2022 15:26
@arilow
Copy link

arilow commented Apr 27, 2022

The changes proposed in this PR have been tested and they work properly. They might be merged in a future release.

Thanks for your contribution to Cardboard!

@arilow
Copy link

arilow commented May 11, 2022

Hi @mtschoen after doing some more testing, we found that, with these changes, the new input system does not work on iOS.

Does it work on your end?

@mtschoen
Copy link
Author

I'll be honest--while I was able to boot up an old mac to make the build I didn't stick around to test end-to-end. I can give that a try soon, though.

@mtschoen
Copy link
Author

It looks like the issue came up as a result of a bad merge, or something. All I did was rebuild the GfxPluginCardboard.a library and it's working again. My latest push should fix the issue.

As a side-note, it might be helpful to set up .gitignore entries in googlevr/cardboard for the files that are added by pod install and the XCode build process. I added a .gitignore to this repo to hide the .DS_Store files I got from opening folders on macOS.

@lneumarkt
Copy link

Hi @mtschoen! Your proposed changes have been internally merged and they will be included in the next release of Cardboard.
Thank you for your contribution to Cardboard!

@xinyunh0929
Copy link
Member

This was merged in 1.24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants