Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep task results if available and update logs/counter #1559

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Keep task results if available and update logs/counter #1559

merged 1 commit into from
Oct 1, 2024

Conversation

aarontp
Copy link
Member

@aarontp aarontp commented Oct 1, 2024 •
edited by wajihyassine
Loading

Description of the change

  • Keep task results in the task manager when it's available so we don't overwrite the failure status message from the Tasks.
  • Update a couple log lines
  • Add a counter for failed tasks so we can compare worker view and server view of failed tasks.

Applicable issues

Additional information

Checklist

  • All tests were successful.
  • Unit tests added.
  • Documentation updated.

@aarontp aarontp requested a review from wajihyassine October 1, 2024 23:18
wajihyassine
wajihyassine approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@wajihyassine wajihyassine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wajihyassine wajihyassine merged commit 252410c into google:master Oct 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wajihyassine wajihyassine wajihyassine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aarontp @wajihyassine