add option to enable rtti, set default to current behavior #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution! We're not currently interested in contributions to the build configuration. We now have a paragraph explaining the situation in https://github.com/google/snappy/blob/master/README.md#contributing-to-the-snappy-project |
4 tasks
andrewseidl
added a commit
to andrewseidl/snappy-feedstock
that referenced
this pull request
Oct 14, 2022
Snappy 1.1.9 explicitly disables RTTI support, which ends up breaking some downstream libraries like Folly (facebook/folly#1606). Snappy upstream is not accepting build-related patches to add an option to change this behavior (google/snappy#147), so adding a patch here to add it. Resolves conda-forge#31
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull requests #144 #143 #129 have all attempted to remove the disable of rtti, but they did not maintain the current build behavior. This change adds a CMake
optionallowing rtti to be enabled if consumers wish to, but it is disabled by default.