This repository was archived by the owner on Oct 11, 2024. It is now read-only.
go mod tidy #1466
Merged
go mod tidy #1466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1466 +/- ##
==========================================
+ Coverage 67.83% 68.05% +0.22%
==========================================
Files 54 54
Lines 4026 4026
==========================================
+ Hits 2731 2740 +9
+ Misses 893 884 -9
Partials 402 402
Continue to review full report at Codecov.
|
RJPercival
reviewed
Feb 17, 2020
| @@ -21,7 +20,7 @@ require ( | |||
| github.com/golang/protobuf v1.3.3 | |||
| github.com/golangci/golangci-lint v1.21.0 // indirect | |||
| github.com/google/certificate-transparency-go v1.1.0 // indirect | |||
| github.com/google/go-cmp v0.3.1 | |||
| github.com/google/go-cmp v0.4.0 | |||
There was a problem hiding this comment.
I'm surprised go mod tidy has updated a dependency - I thought it just added missing dependencies and pruned unused ones.
There was a problem hiding this comment.
go build and go mod tidy can update dependencies when the graph of minimum versions across all dependencies changes.
RJPercival
approved these changes
Feb 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.