Skip to content
This repository was archived by the owner on Oct 11, 2024. It is now read-only.

Avoid race condition in election test #1460

Merged
merged 1 commit into from
Feb 18, 2020
Merged

Conversation

gdbelvin
Copy link
Contributor

@gdbelvin gdbelvin commented Feb 14, 2020

Avoid race condition in election test

@gdbelvin gdbelvin requested a review from a team as a code owner February 14, 2020 15:57
@gdbelvin gdbelvin requested a review from RJPercival February 14, 2020 15:57
@codecov
Copy link

codecov bot commented Feb 14, 2020

Codecov Report

Merging #1460 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1460   +/-   ##
=======================================
  Coverage   67.83%   67.83%           
=======================================
  Files          54       54           
  Lines        4026     4026           
=======================================
  Hits         2731     2731           
  Misses        893      893           
  Partials      402      402           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 668a377...581a322. Read the comment docs.

@RJPercival
Copy link
Contributor

I recommend adding a go mod tidy test to Travis to stop your go.mod/go.sum lagging behind changes (see Trillian's Travis config for an example).

@gdbelvin
Copy link
Contributor Author

I've removed the mod file changes to clean up the PR.

@gdbelvin gdbelvin merged commit 7f8264c into google:master Feb 18, 2020
@gdbelvin gdbelvin deleted the race branch February 18, 2020 07:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants