Skip to content
This repository was archived by the owner on Oct 11, 2024. It is now read-only.

Fix Docker HEALTHCHECK #1427

Merged
merged 12 commits into from
Jan 8, 2020
Merged

Fix Docker HEALTHCHECK #1427

merged 12 commits into from
Jan 8, 2020

Conversation

gdbelvin
Copy link
Contributor

@gdbelvin gdbelvin commented Jan 7, 2020 •
edited
Loading

@gdbelvin gdbelvin requested a review from a team as a code owner January 7, 2020 17:57
@gdbelvin gdbelvin requested a review from RJPercival January 7, 2020 17:59
golangcibot
golangcibot reviewed Jan 7, 2020
View reviewed changes
@codecov
Copy link

codecov bot commented Jan 7, 2020 •
edited
Loading

Codecov Report

Merging #1427 into master will increase coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1427      +/-   ##
==========================================
+ Coverage   66.31%   66.49%   +0.17%     
==========================================
  Files          54       54              
  Lines        4026     4026              
==========================================
+ Hits         2670     2677       +7     
+ Misses        962      958       -4     
+ Partials      394      391       -3
Impacted Files Coverage Δ
core/integration/client_tests.go 85.24% <0%> (+0.46%) ⬆️
core/sequencer/server.go 74.59% <0%> (+1.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e771a6c...fd1640e. Read the comment docs.

RJPercival
RJPercival reviewed Jan 8, 2020
View reviewed changes
Copy link
Contributor

@RJPercival RJPercival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the PR description to say why you're doing this please?

@RJPercival RJPercival assigned gdbelvin and unassigned RJPercival Jan 8, 2020
@gdbelvin
healthcheck nits
4cbfac9
@gdbelvin
Fix EXPOSE ports
e771a6c
@gdbelvin
Merge branch 'master' into healthcheck
fd1640e 
* master:
  Fix scripts to not depend on KT being in $GOPATH (google#1428)
  Fix permissions on Prometheus config files (google#1429)
@gdbelvin
Copy link
Contributor Author

gdbelvin commented Jan 8, 2020

Updated to address comments

@gdbelvin gdbelvin merged commit 68e4b31 into google:master Jan 8, 2020
@gdbelvin gdbelvin deleted the healthcheck branch January 8, 2020 14:41
@gdbelvin gdbelvin mentioned this pull request Feb 5, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@golangcibot golangcibot golangcibot left review comments

@RJPercival RJPercival RJPercival approved these changes

Assignees

@gdbelvin gdbelvin

@RJPercival RJPercival

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gdbelvin @RJPercival @golangcibot @googlebot