Skip to content
This repository was archived by the owner on Oct 11, 2024. It is now read-only.

Test against fresh builds #1420

Merged
merged 7 commits into from
Jan 2, 2020
Merged

Test against fresh builds #1420

merged 7 commits into from
Jan 2, 2020

Conversation

gdbelvin
Copy link
Contributor

  • Build docker images
  • Inject fresh images into kind (k8 in docker)
  • Set docker image tags

@gdbelvin gdbelvin requested a review from a team as a code owner December 28, 2019 18:45
@codecov
Copy link

codecov bot commented Dec 28, 2019

Codecov Report

Merging #1420 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1420   +/-   ##
=======================================
  Coverage   66.15%   66.15%           
=======================================
  Files          53       53           
  Lines        3986     3986           
=======================================
  Hits         2637     2637           
  Misses        956      956           
  Partials      393      393

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fbe72e...c816b16. Read the comment docs.

@gdbelvin gdbelvin force-pushed the fresh_test branch 2 times, most recently from 7d45337 to 9cbf5cd Compare December 31, 2019 18:03
Copy link
Contributor

@pav-kv pav-kv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on "I trust you to know what it does" basis. Left a minor edit suggestion.

.travis.yml Outdated
@@ -49,6 +50,7 @@ jobs:
if: branch = master AND type != pull_request
install:
- curl -LO "https://storage.googleapis.com/kubernetes-release/release/v1.16.3/bin/linux/amd64/kubectl" && chmod +x kubectl && sudo mv kubectl /usr/local/bin/
- curl -s "https://raw.githubusercontent.com/kubernetes-sigs/kustomize/master/hack/install_kustomize.sh" | bash && sudo mv kustomize /usr/local/bin/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- curl -s "https://raw.githubusercontent.com/kubernetes-sigs/kustomize/master/hack/install_kustomize.sh" | bash && sudo mv kustomize /usr/local/bin/
- curl -s "https://raw.githubusercontent.com/kubernetes-sigs/kustomize/master/hack/install_kustomize.sh" | bash && sudo mv kustomize /usr/local/bin/

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels Jan 2, 2020
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Jan 2, 2020
@gdbelvin gdbelvin merged commit e5421fb into google:master Jan 2, 2020
@gdbelvin gdbelvin deleted the fresh_test branch January 2, 2020 17:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants