build.sh: On Linux force use of latest Clang #8522
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMake will default to GCC if it's available. Force use of the oldest installed Clang instead. This can be overridden with CC, CXX, and CXXFLAGS Fixed: google#8515
poweifeng
reviewed
Mar 13, 2025
| @@ -224,6 +224,17 @@ BUILD_CUSTOM_TARGETS= | |||
| UNAME=$(uname) | |||
| LC_UNAME=$(echo "${UNAME}" | tr '[:upper:]' '[:lower:]') | |||
|
|
|||
| if [[ "$LC_UNAME" == "linux" ]]; then | |||
| # On Linux both GCC and Clang are commonly available, but CMake | |||
There was a problem hiding this comment.
maybe exiting when clang is not available would be helpful as well. Otherwise, we'd get a cmake error that's less scrutable (?).
There was a problem hiding this comment.
actually, looks like this will break our github workflows since we're not using the latest clang version on system but a fixed one.
There was a problem hiding this comment.
I'm still struggling to build anyway. E.g. the SDL2 build isn't picking up stdint.h typedefs, and I am not chasing everything down. So this is getting opportunistic for me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake will default to GCC if it's available.
Force use of the latest Clang instead.
This can be overridden with CC, CXX, and CXXFLAGS
Fixed: #8515