Test $Apply using measles resources #2332
Conversation
|
@DebbieArita Is this PR ready for review ? |
@MJ1998 Yes, this is ready for review. Added a ticket too. |
There was a problem hiding this comment.
nice tests added @DebbieArita ! added a couple review comments for you to address
| @@ -0,0 +1,2 @@ | |||
|
|
|||
| workflow/sampledata/measles-immunizations/Library-IMMZVaccineLibrary.json | |||
There was a problem hiding this comment.
can you remove this file from the the codebase please
| subject = "Patient/IMMZ-Patient-NoVaxeninfant-f", | ||
| ) | ||
|
|
||
| println(jsonParser.encodeResourceToString(carePlan)) |
There was a problem hiding this comment.
remove. we do not want to print in tests
| println(jsonParser.encodeResourceToString(carePlan)) |
|
|
||
| println(jsonParser.encodeResourceToString(carePlan)) | ||
|
|
||
| assertNotNull(carePlan) |
There was a problem hiding this comment.
other than asserting it is not null, are there other things that you can assert within the careplan?
DebbieArita
requested review from
aditya-07,
jingtang10 and
MJ1998
as code owners
|
Updating this test with requested changes... |
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #2345
Description
Clear and concise code change description.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.