Handle opaque directories #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goldmann
force-pushed
the
gh-186-opaque-dirs
branch
2 times, most recently
from
07cfd50 to
8e405f4
Compare
Opaque directories are special case whiteout files. In case an opaque directory is found in a layer, all content inside of this rectory in this layer should be copied to the squashed layer, but any content in layers below that layer on the opaque directory path must be ignored. Fixes #186
goldmann
force-pushed
the
gh-186-opaque-dirs
branch
from
8e405f4 to
4180cf6
Compare
|
LGTM. Thanks! |
|
LGTM I ran some tests locally, including the test case in #186. Works fine. Thank you!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opaque directories are special case whiteout files. In case
an opaque directory is found in a layer, all content inside
of this rectory in this layer should be copied to the squashed
layer, but any content in layers below that layer on the
opaque directory path must be ignored.
Fixes #186