Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: review and clean linter tests #3139

Merged
merged 1 commit into from
Sep 1, 2022
Merged

dev: review and clean linter tests #3139

merged 1 commit into from
Sep 1, 2022

Conversation

ldez
Copy link
Member

@ldez ldez commented Aug 25, 2022

  • convert some tests from run_test.go to simple tests
  • remove golint (deprecated) from global tests (but keep specific golint tests)
  • change one test to be runnable without the Makefile
  • remove skipDirsCommand
  • remove redundant tests
  • add a comment on line directive tests

@ldez ldez added topic: cleanup Related to code, process, or doc cleanup area: tests Continuous integration, tests and other checks labels Aug 25, 2022
@ldez ldez force-pushed the feat/clean-tests branch from fd67f4b to 2c57c88 Compare August 25, 2022 12:44
@ldez ldez force-pushed the feat/clean-tests branch from 2c57c88 to a3a4ae8 Compare August 25, 2022 12:51
@ldez ldez requested a review from bombsimon September 1, 2022 12:17
bombsimon
bombsimon approved these changes Sep 1, 2022
View reviewed changes
Copy link
Member

@bombsimon bombsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice to get rid of golint from the tests! 💯

@ldez ldez merged commit 39f401b into golangci:master Sep 1, 2022
@ldez ldez deleted the feat/clean-tests branch September 1, 2022 16:26
SeigeC pushed a commit to SeigeC/golangci-lint that referenced this pull request Apr 4, 2023
@ldez @SeigeC
dev: review and clean linter tests (golangci#3139)
544901f
@ldez ldez added this to the v1.50 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bombsimon bombsimon bombsimon approved these changes

Assignees
No one assigned
Labels
area: tests Continuous integration, tests and other checks topic: cleanup Related to code, process, or doc cleanup
Projects
None yet
Milestone
v1.50
Development

Successfully merging this pull request may close these issues.
2 participants
@ldez @bombsimon