-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/compile/internal/abi: fix ComputePadding #72805
base: master
Are you sure you want to change the base?
Conversation
Fixes the ComputePadding calculation to take into account the padding added for the current offset. This fixes an issue where padding can be added incorrectly for certain structs. Related: go-delve/delve#3923 Fixes golang#72053
This PR (HEAD: e05e2af) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/656736. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/656736. |
This PR (HEAD: de9b340) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/656736. Important tips:
|
Message from Derek Parker: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/656736. |
Assert what we expect instead of asserting about what we don't want.
This PR (HEAD: f708074) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/656736. Important tips:
|
This PR (HEAD: 6ce1b36) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/656736. Important tips:
|
Message from Jorropo: Patch Set 4: Code-Review+2 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/656736. |
Message from Go LUCI: Patch Set 4: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-03-12T03:38:49Z","revision":"ea0f842165dd31de53e332d73f47cdc606c782c4"} Please don’t reply on this GitHub thread. Visit golang.org/cl/656736. |
Message from Jorropo: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/656736. |
Message from Jorropo: Patch Set 4: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/656736. |
Message from Go LUCI: Patch Set 4: This CL has failed the run. Reason: Tryjob golang/try/gotip-linux-arm64-boringcrypto has failed with summary (view all results):
Build or test failure, click here for results. To reproduce, try Additional links for debugging: Please don’t reply on this GitHub thread. Visit golang.org/cl/656736. |
Message from Go LUCI: Patch Set 4: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/656736. |
Message from Jorropo: Patch Set 4: -Code-Review Please don’t reply on this GitHub thread. Visit golang.org/cl/656736. |
Message from Than McIntosh: Patch Set 4: Code-Review+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/656736. |
Message from Keith Randall: Patch Set 4: Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/656736. |
This PR (HEAD: d53a8ff) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/656736. Important tips:
|
Message from Derek Parker: Patch Set 5: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/656736. |
Message from Keith Randall: Patch Set 5: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/656736. |
Message from Keith Randall: Patch Set 5: Auto-Submit+1 Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/656736. |
Message from Than McIntosh: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/656736. |
Fixes the ComputePadding calculation to take into account
the padding added for the current offset. This fixes an issue
where padding can be added incorrectly for certain structs.
Related: go-delve/delve#3923
Fixes #72053