-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/compile: wrong location list for function argument #72053
Labels
compiler/runtime
Issues related to the Go compiler and/or runtime.
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Comments
@golang/compiler |
CC @thanm maybe? :) In case you've got some interest in this with your DWARF5 work. |
Mentioned this in the Delve <> Go team meeting, but I am taking a look at this and hope to send in a CL this week or the next. |
derekparker
added a commit
to derekparker/go
that referenced
this issue
Mar 11, 2025
Fixes the ComputePadding calculation to take into account the padding added for the current offset. This fixes an issue where padding can be added incorrectly for certain structs. Related: go-delve/delve#3923 Fixes golang#72053
derekparker
added a commit
to derekparker/go
that referenced
this issue
Mar 11, 2025
Fixes the ComputePadding calculation to take into account the padding added for the current offset. This fixes an issue where padding can be added incorrectly for certain structs. Related: go-delve/delve#3923 Fixes golang#72053
derekparker
added a commit
to derekparker/go
that referenced
this issue
Mar 11, 2025
Fixes the ComputePadding calculation to take into account the padding added for the current offset. This fixes an issue where padding can be added incorrectly for certain structs. Related: go-delve/delve#3923 Fixes golang#72053
derekparker
added a commit
to derekparker/go
that referenced
this issue
Mar 11, 2025
Fixes the ComputePadding calculation to take into account the padding added for the current offset. This fixes an issue where padding can be added incorrectly for certain structs. Related: go-delve/delve#3923 Fixes golang#72053
derekparker
added a commit
to derekparker/go
that referenced
this issue
Mar 11, 2025
Fixes the ComputePadding calculation to take into account the padding added for the current offset. This fixes an issue where padding can be added incorrectly for certain structs. Related: go-delve/delve#3923 Fixes golang#72053
derekparker
added a commit
to derekparker/go
that referenced
this issue
Mar 11, 2025
Fixes the ComputePadding calculation to take into account the padding added for the current offset. This fixes an issue where padding can be added incorrectly for certain structs. Related: go-delve/delve#3923 Fixes golang#72053
derekparker
added a commit
to derekparker/go
that referenced
this issue
Mar 11, 2025
Fixes the ComputePadding calculation to take into account the padding added for the current offset. This fixes an issue where padding can be added incorrectly for certain structs. Related: go-delve/delve#3923 Fixes golang#72053
Change https://go.dev/cl/656736 mentions this issue: |
Change https://go.dev/cl/657355 mentions this issue: |
gopherbot
pushed a commit
to golang/debug
that referenced
this issue
Mar 15, 2025
Adds a test for https://go.dev/issue/72053 Note the fix is submitted as https://go.dev/cl/656736 For [golang/go#72053](golang/go#72053) Change-Id: Iea247439f95cce85bf9a1560dd475be5048ec97a GitHub-Last-Rev: dcd050f GitHub-Pull-Request: #22 Reviewed-on: https://go-review.googlesource.com/c/debug/+/657355 Reviewed-by: David Chase <[email protected]> Auto-Submit: Ian Lance Taylor <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
compiler/runtime
Issues related to the Go compiler and/or runtime.
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Given the following program:
For function
main.Address.String
the first entry in the location list looks like this:this is wrong, the total size of this location list is 31 bytes while the type of the variable is only 24 bytes. It looks like a spurious 7 byte empty piece is inserted in the middle of the two fields of the string type, for some reason.
Reproduces on go 1.24, 1.23 and 1.22.
Originally reported as: go-delve/delve#3923
cc @dr2chase
The text was updated successfully, but these errors were encountered: