Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support custom domain for generate fake email #66

Conversation

martinyonatann
Copy link
Contributor

@martinyonatann martinyonatann commented Jan 22, 2025

Background

Previously, fake emails were generated with a random domain. This update allows the user to specify a custom domain for the generated email, providing more flexibility for different testing or mock scenarios.

Summary

  • Added support for custom domains when generating fake emails.
  • Default behavior remains unchanged if no custom domain is specified.

Changes

  • Introduced WithCustomDomain function to set a custom domain.
  • Updated fake email generation logic to use the custom domain.

Impact

  • Backward-compatible.
  • No breaking changes.

@martinyonatann martinyonatann force-pushed the feat/support-custom-domain-when-generate-fake-email branch from b4cc85c to 02de7c1 Compare January 22, 2025 09:48
@rubemlrm rubemlrm self-assigned this Jan 22, 2025
@rubemlrm rubemlrm self-requested a review February 3, 2025 10:41
@rubemlrm rubemlrm assigned martinyonatann and unassigned rubemlrm Feb 3, 2025
Copy link
Contributor

@rubemlrm rubemlrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM 👍

@rubemlrm rubemlrm merged commit 9fb8685 into go-faker:main Feb 4, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants