Perpendicular flap with shell element #17
+665
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Crazy-Rich-Meghan
commented
Mar 20, 2025
Crazy-Rich-Meghan
commented
- Use shell mid-plane to represent elasticity
- Coupled with OpenFOAM via vertex-vertex communication method
- Use volume for visualization
hverhelst
requested changes
Mar 20, 2025
There was a problem hiding this comment.
There are quite some left-over sections commented out, and gsDebugVar calls left in the code. Would be nice to give it a small clean-up.
In addition, try to comment a bit more sections. Maybe we can accompany the file with a .dox file, so that it'll be documented immediately; this is a good practice anyay.
Lastly, it would be nice to have the update of the shell volume (inside the time-loop) as just a function call,i.e. constructShellVolume(mid_surface,thickness) (and maybe some direction to indicate which direction the thickness acts). Is this possible?
| #include <gsPreCICE/gsLookupFunction.h> | ||
|
|
||
| #include <gsAssembler/gsExprEvaluator.h> | ||
| // #include <gsPreCICE/gsPreCICEVectorFunction.h> |
There was a problem hiding this comment.
Suggested change
| // #include <gsPreCICE/gsPreCICEVectorFunction.h> |
Comment on lines
+29
to
+31
| #include <gsKLShell/src/gsMaterialMatrixContainer.h> | ||
| #include <gsKLShell/src/gsMaterialMatrixEval.h> | ||
| #include <gsKLShell/src/gsMaterialMatrixIntegrate.h> |
There was a problem hiding this comment.
These should not be needed. Please test
Suggested change
| #include <gsKLShell/src/gsMaterialMatrixContainer.h> | |
| #include <gsKLShell/src/gsMaterialMatrixEval.h> | |
| #include <gsKLShell/src/gsMaterialMatrixIntegrate.h> |
| #endif | ||
|
|
||
| using namespace gismo; | ||
| const double PI = 3.14159265; |
There was a problem hiding this comment.
Unused
Suggested change
| const double PI = 3.14159265; |
Comment on lines
+86
to
+89
|
|
||
|
|
||
|
|
||
|
|
| << "----------------------\n\n"; | ||
|
|
||
| // 1. construction of a knot vector for each direction | ||
| // 1. Construction of knot vectors for each direction |
There was a problem hiding this comment.
Why are the comments double?
Suggested change
| // 1. Construction of knot vectors for each direction |
Comment on lines
+301
to
+302
|
|
||
| gsDebugVar(quad_shell_xy); |
There was a problem hiding this comment.
Suggested change
| gsDebugVar(quad_shell_xy); |
Comment on lines
+304
to
+308
|
|
||
| // gsMatrix<> displacementData = gsMatrix<>::Zero(3, comPt.rows()); | ||
| // displacementData.setRandom(); | ||
|
|
||
|
|
There was a problem hiding this comment.
Suggested change
| // gsMatrix<> displacementData = gsMatrix<>::Zero(3, comPt.rows()); | |
| // displacementData.setRandom(); | |
Comment on lines
+435
to
+439
| // gsMatrix<> points(2, 1); | ||
| // points.col(0) << 0.5, 1; | ||
|
|
||
| // gsStructuralAnalysisOutput<real_t> writer("./output/pointData.csv", points); | ||
| // writer.init({"x", "y", "z"}, {"time"}); // point1 - x, point1 - y, point1 - z, time |
There was a problem hiding this comment.
Suggested change
| // gsMatrix<> points(2, 1); | |
| // points.col(0) << 0.5, 1; | |
| // gsStructuralAnalysisOutput<real_t> writer("./output/pointData.csv", points); | |
| // writer.init({"x", "y", "z"}, {"time"}); // point1 - x, point1 - y, point1 - z, time |
Comment on lines
+455
to
+465
|
|
||
| // gsMatrix<> deformed_thickness(greville.cols(), 3); | ||
|
|
||
| // for (index_t k = 0; k != quad_uv.rows(); k++) | ||
| // { | ||
| // N_shell.row(k) = ev.eval(sn(G_shell).normalized(), quad_uv.row(k)); | ||
| // deformed_thickness.row(k) = N_shell.row(k) * T_shell(0, k); | ||
| // } | ||
|
|
||
| gsDebugVar("Got here 3"); | ||
|
|
There was a problem hiding this comment.
Suggested change
| // gsMatrix<> deformed_thickness(greville.cols(), 3); | |
| // for (index_t k = 0; k != quad_uv.rows(); k++) | |
| // { | |
| // N_shell.row(k) = ev.eval(sn(G_shell).normalized(), quad_uv.row(k)); | |
| // deformed_thickness.row(k) = N_shell.row(k) * T_shell(0, k); | |
| // } | |
| gsDebugVar("Got here 3"); |
Comment on lines
+485
to
+502
|
|
||
| // assembler.assemble(); | ||
| // F = assembler.rhs(); | ||
|
|
||
| gsDebugVar(bcInfo); | ||
|
|
||
| participant.readData(SolidMesh, StressData, quadPointIDs, ForceData); | ||
|
|
||
|
|
||
|
|
||
| // Is this really an average? (maybe need to consider normal vector) | ||
| gsDebugVar(ForceData.rows()); | ||
| gsDebugVar(ForceData.cols()); | ||
| gsDebugVar(N.rows()); | ||
| gsDebugVar(N.cols()); | ||
| gsDebugVar(quadPointsData.rows()); | ||
| gsDebugVar(quadPointsData.cols()); | ||
| gsDebugVar(quad_uv.cols()); |
There was a problem hiding this comment.
Suggested change
| // assembler.assemble(); | |
| // F = assembler.rhs(); | |
| gsDebugVar(bcInfo); | |
| participant.readData(SolidMesh, StressData, quadPointIDs, ForceData); | |
| // Is this really an average? (maybe need to consider normal vector) | |
| gsDebugVar(ForceData.rows()); | |
| gsDebugVar(ForceData.cols()); | |
| gsDebugVar(N.rows()); | |
| gsDebugVar(N.cols()); | |
| gsDebugVar(quadPointsData.rows()); | |
| gsDebugVar(quadPointsData.cols()); | |
| gsDebugVar(quad_uv.cols()); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.