[cmds] Fix mouse release bug in paint event code #2261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Drawing is probably a bit slow so the user tend to keep mouse down and moving. So after releasing the mouse button paint continues to draw for 1 or 2 seconds more on my Amstrad because of the extra buffered events. Also ctrl+z will be usefull to remove the last mouse down until mouse up (the last drawing). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes occasional problem where mouse button up processing was delayed until after next mouse movement in portable event code used in
paint.Also adds 'm' command to
paintto switch between 16x16 and 8x8 mouse cursor for slow systems. Discussed with @toncho11 in #2259 (comment).paintmain loop moved from polling to hanging on select for all events, thus reducing CPU load for any other applications running.Event code cleaned up and mouse position returned in all events. This code will be ported back to 8086-toolchain/examples in the future.