Implement as_hal for BLASes and TLASes
#7303
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # wgpu-core/src/command/ray_tracing.rs # wgpu-core/src/resource.rs # wgpu/src/api/blas.rs # wgpu/src/api/tlas.rs # wgpu/src/backend/wgpu_core.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Description
Adds
as_halfunctions, also allows the acceleration structures to be marked as built. This is mostly built to be a replacement tocommand_encoder_build_acceleration_structures_unsafe_tlasbut I'm going to make a followup that does that.Testing
None, no other as_hal api has testing, though it could be added if wanted.
Squash or Rebase?
Squash
Checklist
cargo fmt.taplo format.cargo clippy. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.