Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove HTTP Basic-Auth repository support #113

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sheepman4267
Copy link
Member

@sheepman4267 sheepman4267 commented Mar 13, 2025

This completely removes support for authenticating to eopkg repositories using HTTP Basic-Auth.
Closes #108.

Rationale

  1. This isn't something we use or have any reason to use officially.
  2. No one on the team has a worthwhile test case for this functionality.
  3. eopkg has an abundance of features which are rarely or never used, and the codebase is very difficult to maintain. Removing unused or impractical non-features such as this reduces code complexity and test surface area.

Test Plan

  1. Check out this PR.
  2. Try eopkg --username=someuser <command> and note that you now receive an error.
  3. Do the same test with --password and the shorthand arguments -p and -u.
  4. Try some basic operations requiring fetches from the server (install, remove, update, fetch, etc.) normally and see that they still work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove basic auth support
1 participant