Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(node): Bump cross-spawn@^6.0.5 #2395

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

szokeasaurusrex
Copy link
Member

Bump the cross-spawn@^6.0.5 subdependency to the latest 6.x version, 6.0.6.

Bump the `cross-spawn@^6.0.5` subdependency to the latest `6.x` version, `6.0.6`.
@szokeasaurusrex szokeasaurusrex enabled auto-merge (squash) February 19, 2025 14:18
@szokeasaurusrex szokeasaurusrex requested review from lforst and Lms24 and removed request for lforst February 19, 2025 14:18
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So to summarize, this doesn't only bump cross-spawn but it also changes a semver lock entry. If this is intended, no worries!

version "2.34.1"
resolved "https://registry.yarnpkg.com/@sentry/cli-win32-x64/-/cli-win32-x64-2.34.1.tgz#40a5f9aba47c1e3b20dd10982643004f89b0d918"
integrity sha512-mU48VpDTwRgt7/Pf3vk/P87m4kM3XEXHHHfq9EvHCTspFF6GtMfL9njZ7+5Z+7ko852JS4kpunjZtsxmoP4/zA==
"@sentry/[email protected]":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these @sentry/cli-* changes are unrelated 🤔 but it makes sense to me that we bump the version so feel free to leave it in

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, yarn just bumped them automatically, based on the package.json I think

Comment on lines +3273 to +3274
semver@^5.5.0:
version "5.7.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one seems unrelated, too but no objections on first glance

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

semver@^5.5.0 is a dependency of cross-spawn, so that is probably why

@szokeasaurusrex szokeasaurusrex merged commit 2ec0c30 into master Feb 19, 2025
14 checks passed
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/bump-cross-spawn branch February 19, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants