Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Improve error handling in dif.rs #2225

Merged
merged 5 commits into from
Nov 7, 2024
Merged

fix: Improve error handling in dif.rs #2225

merged 5 commits into from
Nov 7, 2024

Conversation

loewenheim
Copy link
Contributor

This removes some redundant map_err calls and adds context to DifFile::open_path.

@loewenheim
fix: Improve error handling in dif.rs
bb812f4 
This removes some redundant `map_err` calls and
adds context to `DifFile::open_path`.
@loewenheim
Unnecessary closure
04d9d4f
@loewenheim
Fix tests
05ffaad
@loewenheim loewenheim self-assigned this Nov 7, 2024
szokeasaurusrex
szokeasaurusrex approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@szokeasaurusrex szokeasaurusrex mentioned this pull request Nov 7, 2024
Closed
8 tasks
@loewenheim loewenheim merged commit 9f46b06 into master Nov 7, 2024
14 checks passed
@loewenheim loewenheim deleted the fix/dif-errors branch November 7, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szokeasaurusrex szokeasaurusrex szokeasaurusrex approved these changes

Assignees

@loewenheim loewenheim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loewenheim @szokeasaurusrex