Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc: migrate invoice_errors to error_details #3211

Merged
merged 13 commits into from
Mar 10, 2025

Conversation

annvelents
Copy link
Contributor

@annvelents annvelents commented Feb 18, 2025

Description

Migrated InvoiceError into ErrorDetails with code: 'invoice_generation_error', while keeping the whole logic for invoice_error:

  • invoice can have only one invoice_generation_error
  • error_detail keeps all data for invocie, subscriptions, error, backtrace

@annvelents annvelents force-pushed the misc-error-details-as-invoice-errors branch 4 times, most recently from e847f94 to 23caedd Compare February 24, 2025 10:18
@annvelents annvelents marked this pull request as ready for review February 24, 2025 10:38
Copy link
Collaborator

@vincent-pochet vincent-pochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@annvelents annvelents force-pushed the misc-error-details-as-invoice-errors branch 2 times, most recently from 73c8961 to 9c49e47 Compare March 10, 2025 09:42
@annvelents annvelents merged commit 78598d6 into main Mar 10, 2025
6 checks passed
@annvelents annvelents deleted the misc-error-details-as-invoice-errors branch March 10, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants