Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support priority in SQL storage backends #533

Merged
merged 15 commits into from
Mar 17, 2025

Conversation

derekleverenz
Copy link
Contributor

@derekleverenz derekleverenz commented Mar 16, 2025

Addresses #531

Adds a Priority column to the sqlite, mysql, and postgres backends, and adds Priority to the SqlContext, jobs with a higher priority will be executed first

@derekleverenz derekleverenz changed the title Support priority in SQL sotrages Support priority in SQL storage backends Mar 16, 2025
@derekleverenz derekleverenz marked this pull request as ready for review March 16, 2025 23:48
Copy link
Owner

@geofmureithi geofmureithi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I have left some few thoughts will possibly look more into it

@derekleverenz
Copy link
Contributor Author

Got the priority tests working. I think the existing failure for mysql is unrelated, that test seems flaky

Copy link
Owner

@geofmureithi geofmureithi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thanks for the good work!

@geofmureithi geofmureithi merged commit b330d4f into geofmureithi:main Mar 17, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants