Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applied Ruff formatting and added kwarg to SimpleTestResourceWrapper … #22

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

riebecj
Copy link

@riebecj riebecj commented Feb 11, 2025

…to disable debug capture

@CLAassistant
Copy link

CLAassistant commented Feb 11, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@gchqdev227 gchqdev227 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @riebecj,

Thank you for opening the PR. It's a bit of a pain, but please could I ask that you undo the ruff formatting you've applied, as it's not a style we're applying across the codebase. I'm aware this isn't mentioned in the contribution guide, so I'll make a note to update that ASAP.

Once that's done I'll take a look at the implementation and run the tests.

@riebecj
Copy link
Author

riebecj commented Feb 12, 2025

Hi @riebecj,

Thank you for opening the PR. It's a bit of a pain, but please could I ask that you undo the ruff formatting you've applied, as it's not a style we're applying across the codebase. I'm aware this isn't mentioned in the contribution guide, so I'll make a note to update that ASAP.

Once that's done I'll take a look at the implementation and run the tests.

What format do you use within your code? There doesn't seem to be any apparent code formatting.

@gchqdev227
Copy link
Member

@riebecj the pre-commit checks will run flake8 to enforce PEP-8, but other than isort for the imports, it mostly comes down to what is the most readable.

That, and double-quote strings!

@gchqdev227 gchqdev227 marked this pull request as draft March 19, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for disabling output capture in SimpleTestResourceWrapper to allow using pdb in tests.
3 participants