fix: prevent focus gained/lost loop on wayland #117
Merged
+15
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
folke
commented
Jun 18, 2023
|
Thanks for this PR ! I can't confirm it works but it seems ok! I'm waiting for some feedback and I'll merge later. |
|
Even if we don't have feedback, I think we can merge this PR. What do you think @folke ? |
|
I use Hyprland and didn't have the issue there, probably because If you would like to trigger the original issue, open Neovim in Kitty, on Gnome (with wayland) using That would create an endless loop and makes Neovim unresponsive. The fix in this PR is to make sure that loop no longer happens. Should be safe to merge as is. I can't think of any situation where that kind of behavior would be wanted with the other clipboard handlers. |
|
Thanks ! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On wayland, when getting the contents of the system clipboard with
wl-paste,wl-pasteis launched.wl-pastegets the window focus, so NEovimFocusLostis triggered.This triggers an endless loop of focus lost/gained.
This PR fixes that.
Fixes #37