Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note which options are not used by licensed games #108

Merged
merged 6 commits into from
Feb 22, 2021
Merged

Note which options are not used by licensed games #108

merged 6 commits into from
Feb 22, 2021

Conversation

daid
Copy link
Contributor

@daid daid commented Jan 29, 2021

So both ROM developers know that they shouldn't use those options, and Emulator developers know that there isn't a "correct" way to implement these options.

So both ROM developers know that they shouldn't use those options, and Emulator developers know that there isn't a "correct" way to implement these options.
Copy link
Member

@avivace avivace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me, just the licence -> license spelling

@TheThief
Copy link
Contributor

TheThief commented Jan 29, 2021

I prefer the term "production cartridges" (or just "cartridges"). Various third-party cartridges were released that weren't officially licensed games.

Also, not every cartridge was a game.

@daid
Copy link
Contributor Author

daid commented Jan 29, 2021

I prefer the term "production cartridges" (or just "cartridges"). Various third-party cartridges were released that weren't officially licensed games.

Also, not every cartridge was a game.

Small issue with that, the cartridge list says there is 1 with the 2kb sram option, but it is marked as unlicensed. I haven't checked if this is actually a cart that was produced.

@CasualPokePlayer
Copy link
Contributor

I prefer the term "production cartridges" (or just "cartridges"). Various third-party cartridges were released that weren't officially licensed games.
Also, not every cartridge was a game.

Small issue with that, the cartridge list says there is 1 with the 2kb sram option, but it is marked as unlicensed. I haven't checked if this is actually a cart that was produced.

The cartridge list also has various ROM hacks, and it's probably unlikely all of them actually produce cartridges of these hacks.

@ISSOtm ISSOtm requested a review from avivace January 30, 2021 20:33
@daid
Copy link
Contributor Author

daid commented Feb 5, 2021

Of the 9438 roms I could find, only 102 use the 2KB ram option. All of those are (PD) or (Unl), and a few are marked as bad dumps. And 15 roms use values > 0x05 for the RAM field.

None of the 9438 roms use ROM+RAM or ROM+RAM+BATTERY.

None of the 9438 roms use ROM size $52, $53 or $54. And there are only 5 roms which have out of range values which are all (Unl)

And, I found zero roms that have the CGB flag sets for "PGB mode" which is currently mentioned in the pandocs as "TODO + Research"

@ISSOtm
Copy link
Member

ISSOtm commented Feb 10, 2021

PGB mode was confirmed by @LIJI32, so it's definitely real.

If 2K cannot be confirmed, then I suggest again "Unused, *) but unofficial docs list it as 2 KB".

Once that is done, unless @avivace has other opposition, this should be merged.

@LIJI32
Copy link
Contributor

LIJI32 commented Feb 10, 2021

PGB mode probably can't even be used in plain ROMs because it seems to require very dedicated hardware in the cartridge instead of a plain ROM+MBC.

@avivace
Copy link
Member

avivace commented Feb 11, 2021

LGTM, thanks everybody.

Can we add the unconfirmed/unused note on the 2 KB thingy?

@ISSOtm
Copy link
Member

ISSOtm commented Feb 18, 2021

Ping @daid

@daid
Copy link
Contributor Author

daid commented Feb 18, 2021

Sorry, it slipped my notification list. So thanks for the ping.

I've also marked the rom sizes > $50 as unofficial. As zero roms in my giant rom set use this option, and there is no documentation to backup this claim, and it doesn't really make sense to have those sizes of rom.

My guess it that it was used by someone in an attempt to "fix" certain bad dumps or something, where they didn't understand the MBC and thus got a strange number of banks.

@TheThief
Copy link
Contributor

I would remove the >$50 sizes from the table and put a note underneath that other docs mention them but the source is unknown and no known ROMs use them.

I had this in my other pull request:

The following ROM types are listed on some older unofficial documentation but the source is unknown, and no cartridges or ROMs using them are known.

|code | Size      | Banks |
|-----|-----------|--------------|
| $52 | 1.1 MByte | 72 banks |
| $53 | 1.2 MByte | 80 banks |
| $54 | 1.5 MByte | 96 banks |

@avivace
Copy link
Member

avivace commented Feb 19, 2021

This looks good to me, but @TheThief solution also makes sense and maybe this could set a precedent (keep unconfirmed stuff separate)

@daid
Copy link
Contributor Author

daid commented Feb 20, 2021

While TheThiefs solution works really well for tge rom size, I would preferrer keeping a table sorted over 2 tables.

@ISSOtm ISSOtm merged commit b96e53b into gbdev:develop Feb 22, 2021
@daid daid deleted the patch-3 branch February 22, 2021 11:33
@GPHemsley GPHemsley mentioned this pull request Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants